Skip to content

feat(wanda): add digest subcommand to wanda CLI#455

Merged
andrew-anyscale merged 1 commit intomainfrom
andrew/revup/main/wanda-digest-cli
Mar 11, 2026
Merged

feat(wanda): add digest subcommand to wanda CLI#455
andrew-anyscale merged 1 commit intomainfrom
andrew/revup/main/wanda-digest-cli

Conversation

@andrew-anyscale
Copy link
Contributor

Extends the wanda CLI with a 'digest' subcommand that calls
wanda.Digest and prints the content-addressed digest to stdout.
Supports both local mode (spec file as positional argument) and
RayCI mode (spec file from RAYCI_WANDA_FILE).

Topic: wanda-digest-cli
Relative: wanda-digest
Signed-off-by: andrew andrew@anyscale.com

@andrew-anyscale
Copy link
Contributor Author

andrew-anyscale commented Mar 10, 2026

Reviews in this chain:
#455 feat(wanda): add digest subcommand to wanda CLI

@andrew-anyscale
Copy link
Contributor Author

andrew-anyscale commented Mar 10, 2026

# head base diff date summary
0 c5bcc089 ae7dff66 diff Mar 10 13:25 PM 1 file changed, 14 insertions(+)
1 aed9f07d 50233428 diff Mar 10 13:48 PM 1 file changed, 7 insertions(+), 8 deletions(-)
2 bd2c4b22 50233428 diff Mar 10 13:51 PM 1 file changed, 4 insertions(+), 2 deletions(-)
3 54c27a47 62b6215f rebase Mar 10 18:06 PM 0 files changed
4 c43fc088 2b8ead37 rebase Mar 10 18:09 PM 0 files changed
5 af6c1f32 953c2390 diff Mar 10 18:36 PM 1 file changed, 21 insertions(+), 21 deletions(-)

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the wanda command-line interface by integrating a new digest subcommand. This addition provides users with a lightweight method to quickly retrieve the content-addressed digest of a given spec file, bypassing the need for a full build process. This capability is particularly useful for validation, debugging, or integration with other systems that rely on content hashes, streamlining workflows for both local development and RayCI environments.

Highlights

  • New digest subcommand: Introduced a digest subcommand to the wanda CLI, allowing users to print the content-addressed digest of a spec file without triggering a full build. This subcommand supports both local file input and RayCI environment variables.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • wanda/wanda/main.go
    • Added a new digest subcommand to the wanda CLI.
    • Implemented logic to parse the digest subcommand argument.
    • Integrated the call to wanda.Digest when the digest subcommand is used.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a digest subcommand to the wanda CLI, which is a useful feature. The implementation, however, introduces ambiguity in command-line argument parsing. My review focuses on suggesting a more robust subcommand handling mechanism to prevent potential bugs and improve maintainability, for instance when trying to process a file named digest.

@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/main/wanda-digest branch from ae7dff6 to 5023342 Compare March 10, 2026 20:48
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/main/wanda-digest-cli branch 2 times, most recently from aed9f07 to bd2c4b2 Compare March 10, 2026 20:51
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/main/wanda-digest branch from 5023342 to 62b6215 Compare March 11, 2026 01:06
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/main/wanda-digest-cli branch 2 times, most recently from 54c27a4 to c43fc08 Compare March 11, 2026 01:09
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/main/wanda-digest branch from 62b6215 to 2b8ead3 Compare March 11, 2026 01:09
if digest {
os.Args = append(os.Args[:1], os.Args[2:]...)
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to use flagset for flag parsing? so that we are not manipulating the value of os.Args ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, updated!

Base automatically changed from andrew/revup/main/wanda-digest to main March 11, 2026 01:36
Extends the wanda CLI with a 'digest' subcommand that calls
wanda.Digest and prints the content-addressed digest to stdout.
Supports both local mode (spec file as positional argument) and
RayCI mode (spec file from RAYCI_WANDA_FILE).

Topic: wanda-digest-cli
Relative: wanda-digest
Signed-off-by: andrew <andrew@anyscale.com>
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/main/wanda-digest-cli branch from c43fc08 to af6c1f3 Compare March 11, 2026 01:36
@andrew-anyscale andrew-anyscale merged commit 42ee12e into main Mar 11, 2026
2 checks passed
@andrew-anyscale andrew-anyscale deleted the andrew/revup/main/wanda-digest-cli branch March 11, 2026 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants