feat(wanda): add digest subcommand to wanda CLI#455
Conversation
|
Reviews in this chain: |
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds a digest subcommand to the wanda CLI, which is a useful feature. The implementation, however, introduces ambiguity in command-line argument parsing. My review focuses on suggesting a more robust subcommand handling mechanism to prevent potential bugs and improve maintainability, for instance when trying to process a file named digest.
ae7dff6 to
5023342
Compare
aed9f07 to
bd2c4b2
Compare
5023342 to
62b6215
Compare
54c27a4 to
c43fc08
Compare
62b6215 to
2b8ead3
Compare
| if digest { | ||
| os.Args = append(os.Args[:1], os.Args[2:]...) | ||
| } | ||
|
|
There was a problem hiding this comment.
change to use flagset for flag parsing? so that we are not manipulating the value of os.Args ?
There was a problem hiding this comment.
Good call, updated!
Extends the wanda CLI with a 'digest' subcommand that calls wanda.Digest and prints the content-addressed digest to stdout. Supports both local mode (spec file as positional argument) and RayCI mode (spec file from RAYCI_WANDA_FILE). Topic: wanda-digest-cli Relative: wanda-digest Signed-off-by: andrew <andrew@anyscale.com>
c43fc08 to
af6c1f3
Compare
Extends the wanda CLI with a 'digest' subcommand that calls
wanda.Digest and prints the content-addressed digest to stdout.
Supports both local mode (spec file as positional argument) and
RayCI mode (spec file from RAYCI_WANDA_FILE).
Topic: wanda-digest-cli
Relative: wanda-digest
Signed-off-by: andrew andrew@anyscale.com