[rayapp] including darwin arm64 rayapp binary#456
Conversation
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request expands the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
There was a problem hiding this comment.
Code Review
This pull request adds the darwin arm64 build target for the rayapp binary in the release script. The change is straightforward and aligns with the goal of expanding platform support. I have one suggestion to improve the consistency of the script, which will enhance its readability and maintainability.
| build_raycilint linux arm64 | ||
|
|
||
| build_rayapp linux amd64 | ||
| build_rayapp darwin arm64 |
There was a problem hiding this comment.
To improve consistency with other build commands in this file, I suggest a couple of adjustments:
- Ordering: The build commands for other tools like
raycilintandwandaare sorted by OS (darwinbeforelinux). To follow this pattern, this line should be placed before thebuild_rayapp linux amd64line. - Spacing: Most build commands in this file use two spaces between the OS and architecture for alignment. Please adjust the spacing here as well (e.g.,
darwin arm64).
These changes will make the script more consistent and easier to maintain.
adding darwin arm64 to rayapp binary release script