Skip to content

[rayapp] including darwin arm64 rayapp binary#456

Merged
elliot-barn merged 2 commits intomainfrom
rayapp-darwin-arm64
Mar 11, 2026
Merged

[rayapp] including darwin arm64 rayapp binary#456
elliot-barn merged 2 commits intomainfrom
rayapp-darwin-arm64

Conversation

@elliot-barn
Copy link
Collaborator

adding darwin arm64 to rayapp binary release script

Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request expands the rayapp binary release process to incorporate darwin arm64 builds. This enhancement ensures that rayapp can be natively distributed and run on Apple Silicon Macs, providing improved performance and a better user experience for those platforms.

Highlights

  • Rayapp Binary Release: Added support for building and releasing the rayapp binary for darwin arm64 architecture, enabling native compatibility with Apple Silicon Macs.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • release.sh
    • Included darwin arm64 as a target for rayapp binary builds in the release script.
Activity
  • No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the darwin arm64 build target for the rayapp binary in the release script. The change is straightforward and aligns with the goal of expanding platform support. I have one suggestion to improve the consistency of the script, which will enhance its readability and maintainability.

build_raycilint linux arm64

build_rayapp linux amd64
build_rayapp darwin arm64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve consistency with other build commands in this file, I suggest a couple of adjustments:

  1. Ordering: The build commands for other tools like raycilint and wanda are sorted by OS (darwin before linux). To follow this pattern, this line should be placed before the build_rayapp linux amd64 line.
  2. Spacing: Most build commands in this file use two spaces between the OS and architecture for alignment. Please adjust the spacing here as well (e.g., darwin arm64).

These changes will make the script more consistent and easier to maintain.

@elliot-barn elliot-barn merged commit d3197ad into main Mar 11, 2026
2 checks passed
@elliot-barn elliot-barn deleted the rayapp-darwin-arm64 branch March 11, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants