[raycicmd] Add fetch_full_history parameter to command steps#458
[raycicmd] Add fetch_full_history parameter to command steps#458andrew-anyscale merged 1 commit intomainfrom
Conversation
|
Reviews in this chain: |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the RayCI command step configuration by allowing users to specify whether a shallow Git clone should be unshallowed during the build process. This change addresses issues where certain Git-dependent scripts fail in shallow clone environments by providing a mechanism to ensure a complete Git history is available when needed, thereby improving the reliability of CI checks. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces an unshallow_checkout parameter for command steps. When this parameter is set to true, the RAYCI_UNSHALLOW_CHECKOUT=1 environment variable is added to the step's environment. The implementation correctly updates the allowed and dropped keys for command steps, and a new test case has been added to verify the functionality. The changes are well-implemented and look correct.
507ab5f to
0fe8b49
Compare
When fetch_full_history: true is set on a command step in .rayci.yml, the generated Buildkite step gets RAYCI_FETCH_FULL_HISTORY=1 in its env. The pre-command hook on the host reads this and runs git fetch --unshallow before docker starts, so steps that need full git history (e.g. git merge-base) work correctly with shallow clones. Topic: unshallow-command Signed-off-by: andrew <andrew@anyscale.com>
0fe8b49 to
9eb3e1c
Compare
When fetch_full_history: true is set on a command step in .rayci.yml, the generated Buildkite step gets RAYCI_FETCH_FULL_HISTORY=1 in its env. The pre-command hook on the host reads this and runs git fetch --unshallow before docker starts, so steps that need full git history (e.g. git merge-base) work correctly with shallow clones.
Topic: unshallow-command
Signed-off-by: andrew andrew@anyscale.com