feat: add statusCode, code, and description to RazorpayException#349
Open
sahilleth wants to merge 1 commit intorazorpay:masterfrom
Open
feat: add statusCode, code, and description to RazorpayException#349sahilleth wants to merge 1 commit intorazorpay:masterfrom
sahilleth wants to merge 1 commit intorazorpay:masterfrom
Conversation
Enables programmatic error handling for API errors (retry logic, rate limiting, branching by error type). Backward compatible. - Add getStatusCode(), getCode(), getDescription() getters - Populate from API error responses in ApiClient - Use optString for optional code/description (OAuth compatibility) - Add serialVersionUID for safe serialization - Add RazorpayExceptionTest and error-path test in PaymentClientTest Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
statusCode,code, anddescriptiontoRazorpayExceptionto support programmatic error handling.Problem
RazorpayExceptiononly exposesgetMessage(), so callers must parse strings to handle different API errors (e.g. 400 vs 404 vs 429). This makes retries, rate limiting, and branching by error type difficult.Solution
getStatusCode(),getCode(),getDescription()toRazorpayExceptionApiClient.throwException()optStringfor optionalcodeanddescription(handles OAuth responses where these may be absent)serialVersionUIDfor serialization compatibilityUsage
try {
Payment payment = razorpayClient.payments.fetch(paymentId);
} catch (RazorpayException e) {
if (Integer.valueOf(429).equals(e.getStatusCode())) {
// Retry with backoff
} else if ("BAD_REQUEST_ERROR".equals(e.getCode())) {
// Handle validation error
}
}
Testing
RazorpayExceptionTest: constructors and getters
PaymentClientTest#fetchThrowsExceptionWithStatusCodeAndErrorCode: API error path