Fix "Show Notifications" menu item and logic#10
Fix "Show Notifications" menu item and logic#10google-labs-jules[bot] wants to merge 1 commit intomainfrom
Conversation
- Enabled the "Show Notifications" menu item in `source/menu.ts` by removing `visible: is.development`. - Updated `source/browser/conversation-list.ts` to respect the `notificationsMuted` configuration setting in `countUnread`. - Removed obsolete TODO comments.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This change fixes the "Show Notifications" menu item by making it visible in production and ensuring that the backend logic in
source/browser/conversation-list.tsrespects thenotificationsMutedsetting. Now, when the user unchecks "Show Notifications", the mutation observer will not trigger notifications for unread messages.PR created automatically by Jules for task 13648007699811232100 started by @raztronaut