Skip to content

Fix: Release microphone after call#12

Draft
google-labs-jules[bot] wants to merge 1 commit intomainfrom
fix/microphone-release-14489419160437826852
Draft

Fix: Release microphone after call#12
google-labs-jules[bot] wants to merge 1 commit intomainfrom
fix/microphone-release-14489419160437826852

Conversation

@google-labs-jules
Copy link

This commit resolves an issue where the microphone would not be released after a video or voice call on macOS, causing the "microphone in use" indicator to remain active.

The solution involves the following changes:

  • Implemented session.setPermissionRequestHandler to manage media permissions for the main window and call popups.
  • Added a did-create-window event listener to track call popups and inject JavaScript to stop the MediaStream when the call window is closed.
  • This ensures that the microphone and camera are properly released after a call, resolving the resource leak.

Fixes #1


PR created automatically by Jules for task 14489419160437826852 started by @raztronaut

This commit resolves an issue where the microphone would not be released after a video or voice call on macOS, causing the "microphone in use" indicator to remain active.

The solution involves the following changes:

- Implemented `session.setPermissionRequestHandler` to manage media permissions for the main window and call popups.
- Added a `did-create-window` event listener to track call popups and inject JavaScript to stop the `MediaStream` when the call window is closed.
- This ensures that the microphone and camera are properly released after a call, resolving the resource leak.
@google-labs-jules
Copy link
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release of microphone after call

0 participants