Skip to content

Consolidate notification fixes and performance optimizations#17

Draft
google-labs-jules[bot] wants to merge 1 commit intomainfrom
consolidate-notifications-7246769853686056226
Draft

Consolidate notification fixes and performance optimizations#17
google-labs-jules[bot] wants to merge 1 commit intomainfrom
consolidate-notifications-7246769853686056226

Conversation

@google-labs-jules
Copy link

Consolidated notification-related fixes and performance optimizations into a single branch.

Key Changes:

  • Menu: Enabled "Show Notifications", "Show Message Preview", and "Show Unread Badge" for all users (removed is.development checks). Removed duplicate menu items.
  • Logic: Updated source/browser/conversation-list.ts to respect notificationsMuted config by suppressing the notification IPC call, while continuing to track unread messages to prevent state desynchronization.
  • Performance: Refactored isUnread to use TreeWalker instead of querySelectorAll for more efficient DOM traversal.
  • Reactivity: Added listeners in source/index.ts to update the unread badge immediately upon config change.
  • Flash Window: Added window flashing logic for non-macOS systems when a message arrives.

PR created automatically by Jules for task 7246769853686056226 started by @raztronaut

- Merged logic from multiple branches to unify notification handling.
- Enabled "Show Notifications", "Show Message Preview", and "Show Unread Badge" menu items for production.
- Implemented `notificationsMuted` check in `conversation-list.ts` to suppress toasts without breaking message tracking.
- Optimized `isUnread` detection using `TreeWalker` for better performance.
- Added reactive unread badge updates and flash window support for non-macOS systems.
- Removed duplicate menu items and development-only flags.
@google-labs-jules
Copy link
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants