Fix "Flash Window on Message" notification feature#4
Fix "Flash Window on Message" notification feature#4google-labs-jules[bot] wants to merge 1 commit intomainfrom
Conversation
- Implemented `mainWindow.flashFrame(true)` in the main process notification handler. - Enabled the "Flash Window on Message" menu item for non-macOS platforms. - Removed TODO comments related to this feature.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR fixes the "Flash Window on Message" feature which was previously disabled and marked as a TODO.
Changes:
source/index.ts, thenotificationIPC handler now checks theflashWindowOnMessageconfig and triggersmainWindow.flashFrame(true)if enabled and not on macOS.source/menu.ts, the menu item visibility is updated to!is.macos(previouslyis.development) and the TODO comments are removed.This ensures that users on Windows and Linux receive a taskbar flash when a new message notification arrives, if the option is enabled.
PR created automatically by Jules for task 5825506827835256528 started by @raztronaut