Skip to content

Improve context menu implementation#6

Draft
google-labs-jules[bot] wants to merge 1 commit intomainfrom
improve-context-menu-implementation-11330314173278163212
Draft

Improve context menu implementation#6
google-labs-jules[bot] wants to merge 1 commit intomainfrom
improve-context-menu-implementation-11330314173278163212

Conversation

@google-labs-jules
Copy link

This change refactors the context menu implementation in source/index.ts to use the menu option provided by electron-context-menu instead of a hacky prepend workaround. This allows for a cleaner and more maintainable way to customize the context menu, specifically for stripping tracking parameters from copied links. Additionally, the "Save Image As" option has been explicitly enabled in the menu configuration.


PR created automatically by Jules for task 11330314173278163212 started by @raztronaut

- Replaced hacky `prepend` solution with `menu` option in `electron-context-menu`.
- Explicitly defined menu items to ensure correct order and visibility.
- Added `saveImageAs` option to the context menu.
- Applied `stripTrackingFromUrl` transform to `copyLink` action properly.
@google-labs-jules
Copy link
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants