Fix "Show Unread Badge" functionality#9
Conversation
- Enable the "Show Unread Badge" menu item in production by removing the `visible: is.development` restriction. - Remove the full page reload on toggle, opting for an immediate update. - Implement reactivity in `source/index.ts` by tracking `currentMessageCount` and listening for configuration changes to `showUnreadBadge`. - Update the tray icon badge instantly when the setting is toggled.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR fixes the "Show Unread Badge" functionality which was previously hidden in development and required a page reload to take effect.
Changes:
source/menu.ts, the menu item is now visible in production and no longer triggers a reload.source/index.ts, added logic to track the current message count and update the badge immediately when theshowUnreadBadgeconfiguration changes.PR created automatically by Jules for task 3095911013241129819 started by @raztronaut