Skip to content

fix: Makefile module path + remove dead code from final review #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rbansal42 merged 1 commit into from
Feb 6, 2026
Merged

fix: Makefile module path + remove dead code from final review #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

VERSION ?= $(shell git describe --tags --always --dirty 2>/dev/null || echo "dev")
BUILD_DATE ?= $(shell date -u +"%Y-%m-%dT%H:%M:%SZ")
LDFLAGS := -ldflags "-X github.com/rbansal42/bb/internal/cmd.Version=$(VERSION) -X github.com/rbansal42/bb/internal/cmd.BuildDate=$(BUILD_DATE)"
LDFLAGS := -ldflags "-X github.com/rbansal42/bitbucket-cli/internal/cmd.Version=$(VERSION) -X github.com/rbansal42/bitbucket-cli/internal/cmd.BuildDate=$(BUILD_DATE)"

build:
go build $(LDFLAGS) -o bin/bb ./cmd/bb
Expand Down
9 changes: 0 additions & 9 deletions internal/cmd/pipeline/view.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import (
"context"
"encoding/json"
"fmt"
"time"

"github.com/spf13/cobra"

Expand Down Expand Up @@ -300,11 +299,3 @@ func capitalize(s string) string {
}
return string(s[0]-32) + s[1:]
}

// formatTimestamp formats a time as a readable timestamp
func formatTimestamp(t time.Time) string {
if t.IsZero() {
return "-"
}
return t.Format("Jan 2, 2006 15:04:05")
}
Loading