fix: address completion follow-up issues (#35-#39, #41)#46
Merged
Conversation
Merge dev: dynamic shell completions
- Add doc comment explaining filterPrefix redundancy with Cobra (#35) - Extract magic numbers into named constants (completionPageLimit, completionPRPageLimit) (#36) - Add Username to member completion fallback chain (#37) - Add --branch flag completion to browse command (#38) - Document 'on hold' space issue in issue list completion (#39) - Add completions for repo clone/delete/view/fork/sync/setdefault (#41) - Add --status and --branch completions to pipeline list (#41) - Add --role completion to snippet list (#41) - Register global --repo persistent flag completion on root command (#41)
- Align pipeline list --status completion values with API state model (use IN_PROGRESS/SUCCESSFUL instead of BUILDING/ERROR) - Remove misleading --branch completion from repo clone (CompleteBranchNames resolves from CWD, not the target repo) - Add clarifying comment on root --repo persistent flag shadowing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses all follow-up issues from the v0.3.0 dynamic shell completions release:
filterPrefixredundancy with Cobra (kept as safety net)50/30into named constants (completionListPageSize,completionDetailPageSize)Usernameto member completion fallback chain (Nickname → Username → DisplayName)--branchflag completion tobrowsecommandrepo clone/delete/view/fork/sync/setdefault— positional and flag completionspipeline list—--statusand--branchcompletionssnippet list—--rolecompletionroot— global persistent--repoflag completionCode Review Fixes
--statuscompletion values with API state model (IN_PROGRESS/SUCCESSFULinstead ofBUILDING/ERROR)--branchcompletion fromrepo clone(resolves from CWD, not target repo)--repopersistent flag shadowing behaviorFollow-up Issues Created
CompleteWorkspaceMembersfallback chain--rolecompletion forworkspace listcommandTesting
go build ./...— passesgo test ./...— all tests passgo vet ./...— clean