Skip to content

Restrict overmatching MACH ifdef to only trigger on OSX and Mach#3

Open
Zopolis4 wants to merge 1 commit intorbsheth:masterfrom
Zopolis4:master
Open

Restrict overmatching MACH ifdef to only trigger on OSX and Mach#3
Zopolis4 wants to merge 1 commit intorbsheth:masterfrom
Zopolis4:master

Conversation

@Zopolis4
Copy link

Hurd also uses Mach, but does not have the same behavior as OSX in this area.
https://www.gnu.org/software/hurd/hurd/porting/guidelines.html

#ifdef __MACH__
Some applications put Apple Darwin-specific code inside #ifdef __MACH__ guards. 
Such guard is clearly not enough, since not only Apple uses Mach as a kernel. 
This should be replaced by #if defined(__MACH__) && defined(__APPLE__)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant