Fix normals Float32 precision loss in JS#4
Open
robert-salata-hl wants to merge 1 commit intorbsheth:masterfrom
Open
Fix normals Float32 precision loss in JS#4robert-salata-hl wants to merge 1 commit intorbsheth:masterfrom
robert-salata-hl wants to merge 1 commit intorbsheth:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some specific geometries, o3dgc.js parser fails due to inaccurate normals computations. The
m_normalsarray was defined asFloat32Array, which does not provide precision necessary for computations performed insideComputeNormalsfunction, later resulting in errorCubeToSphere[nin.m_z] is not a function. The issue can be observed on attached geometrymesh.o3dgc. The same geometry is parsed correctly by c++ parser.mesh.zip
Changing
Float32ArraytoInt32Arrayresolves the issue, and is aligned with c++ implementation - seeOpen3DGC/src/o3dgc_decode_lib/inc/o3dgcSC3DMCDecoder.inlfile,ProcessNormalsfunction. Then0variable stores the same normal values asm_normalsarray in js, and is declared asVec3<long>, notVec3<float>.