Conversation
Author
|
@rbuffat I know you last wrote to this a decade ago, but it would be really useful for me if you were willing to accept changes and deploy to PyPI? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a method to allow for a StringIO object to be passed, instead of a filepath.
For probably bad reasons, we have a number of EPW files stored as text in a DB. Cloud deployments can sometimes have a lot of overhead for file read/write.
Separating the file opening from the reading of the file-like object allows us to parse a StringIO object, which can be from a file, or just from our strings.
The API remains backwards compatible, the previous
readhas been updated to use the stringIO reading function.All tests are passing (changes dir
teststotestbecause unittest was complaining)