Remove unused variables & functions#4
Open
ppartarr wants to merge 1 commit intorchatterjee:masterfrom
Open
Conversation
ppartarr
force-pushed
the
refactor/remove-unused-variables
branch
from
862352d to
cee2a03
Compare
Neighbourhood size is never used & estimated_ball_weight is always positive (product of probability & size of ball)
ppartarr
force-pushed
the
refactor/remove-unused-variables
branch
from
cee2a03 to
c70c2fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nsize is never usedtpw_done&guess_listserve the same purpose, so removetpw_doneestimated_ball_weightis always positive (product of probability and the size of ball)test_success_rateis never called