Skip to content

V1.35 Strip newline characters from 'chem_comp.name'#91

Open
piehld wants to merge 4 commits intomasterfrom
dev-dwp-2
Open

V1.35 Strip newline characters from 'chem_comp.name'#91
piehld wants to merge 4 commits intomasterfrom
dev-dwp-2

Conversation

@piehld
Copy link
Collaborator

@piehld piehld commented Nov 4, 2025

V1.35 Strip newline characters from 'chem_comp.name'

Also, switch to 'pyproject.toml' file and hatch build system, and update pipelines to Python 3.13

@piehld
Copy link
Collaborator Author

piehld commented Nov 4, 2025

Hi @brindakv, could you please take a quick look at rcsb/utils/dictionary/DictMethodChemRefHelper.py? This is a fix to remove newline characters from chem_comp.name, which are currently being retained in ETL: example.

(All other changes in this PR are related to python packaging updates).

Also note that a similar fix was applied here: rcsb/py-rcsb_utils_chemref#17.

@piehld
Copy link
Collaborator Author

piehld commented Dec 2, 2025

Note that this is on pause after discussing this with Data In, as they will review these weird cases and try to fix them up front.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant