RDKB-62620: Coverity Cleanup for CcspCommonLibrary

source/ccsp/components/CCSP_AliasMgr/ccsp_alias_mgr_base.c

@@ -1070,15 +1070,15 @@ CcspAliasMgrLookupAliasNode
                 pChildNode   = pChildNode->Sibling;
             }
         }
-
         if ( !pChildNode )
         {
+	    /* CID: 154680 - Logically Dead code */
             if ( bInsMatched )
             {
                 pChildNode = pInsNode;
                 pInsNode   = NULL;
             }
-        }
+	}
         else if ( !StringSListIsEmpty(&pChildNode->Aliases))
         {
             pAliasNode = pChildNode;

source/ccsp/components/common/DataModel/dml/components/DslhCpeController/dslh_cpeco_control.c

@@ -1,5 +1,5 @@
 /*
  * If not stated otherwise in this file or this component's Licenses.txt file the
  * following copyright and licenses apply:
  *
  * Copyright 2015 RDK Management
@@ -1344,8 +1344,17 @@
             if ( ( CCSP_SUCCESS != returnStatus ) && ( CCSP_CR_ERR_NAMESPACE_OVERLAP != returnStatus ) )
              {
                 AnscTraceWarning(("!!! %s registerCapabilities failed with code %lu! Waiting for %lu seconds to retry...!!! \n", pComponentName, returnStatus, uWait));
-                AnscSleep(uWait * 1000);
-                uWait *=2;
+		/* Convert to ms safely */
+		uint64_t ms = (uint64_t)uWait * 1000ULL;
+
+		/* Clamp for AnscSleep() */
+		if (ms > ULONG_MAX)
+		    ms = ULONG_MAX;
+
+		AnscSleep((ULONG)ms);
+
+		/* Exponential backoff: still in seconds! */
+		uWait = (uWait <= (ULONG_MAX / 2000)) ? (uWait * 2) : (ULONG_MAX / 1000);
             }
             else
             {

source/ccsp/components/common/MessageBusHelper/helper/messagebus_interface_helper.c

@@ -1,5 +1,5 @@
 /*
  * If not stated otherwise in this file or this component's Licenses.txt file the
  * following copyright and licenses apply:
  *
  * Copyright 2015 RDK Management
@@ -1185,17 +1185,17 @@
 
             if( i > 0 )
             {
-                for(--i; (int)i >= 0; --i)
+		for (ULONG k = i; k-- > 0; )
                 {
-                     if(ppReturnVal[i]->parameterName)
+                     if(ppReturnVal[k]->parameterName)
                      {
-                           AnscFreeMemory(ppReturnVal[i]->parameterName);
-                           ppReturnVal[i]->parameterName = NULL;
+                           AnscFreeMemory(ppReturnVal[k]->parameterName);
+                           ppReturnVal[k]->parameterName = NULL;
                      }
-                     if(ppReturnVal[i])
+                     if(ppReturnVal[k])
                      {
-                           AnscFreeMemory(ppReturnVal[i]);
-                           ppReturnVal[i] = NULL;
+                           AnscFreeMemory(ppReturnVal[k]);
+                           ppReturnVal[k] = NULL;
                      }
                 }
             }

source/cosa/package/cli/components/ScliShell/scli_shell_bic.c

@@ -1,5 +1,5 @@
 /*
  * If not stated otherwise in this file or this component's Licenses.txt file the
  * following copyright and licenses apply:
  *
  * Copyright 2015 RDK Management
@@ -1748,8 +1748,10 @@
                 ScliShoInitArgMatchResult(&pOptArgM[i]);
             }
         }
-
-        /* trying to auto complete argument name or value */
+	if ( !pReqArgM || !pOptArgM ) {
+	    goto EXIT;
+	}
+	/* trying to auto complete argument name or value */
         bMatched = 
             ScliShoMatchCommand
                 (
@@ -2397,6 +2399,10 @@
                 }
             }
 
+	    if ( !pReqArgM || !pOptArgM )
+	    {
+		goto EXIT;
+	    }
             bMatched = 
                 ScliShoMatchCommand
                     (

source/cosa/package/cli/components/ScliShell/scli_shell_exec.c

@@ -1,5 +1,5 @@
 /*
  * If not stated otherwise in this file or this component's Licenses.txt file the
  * following copyright and licenses apply:
  *
  * Copyright 2015 RDK Management
@@ -134,8 +134,7 @@
                         (ANSC_HANDLE)pMyObject,
                         hSrvSession
                     );
-
-            CmdRequest.CurLineNumber    = nRow - 1;
+	    CmdRequest.CurLineNumber = (nRow > 0) ? (ULONG)(nRow - 1) : 0;
 
             if ( ulInputMode == SCLI_SHELL_INPUT_MODE_linemode && nRow > 0 )
             {

source/cosa/package/cli/components/ScliShell/scli_shell_help.c

@@ -1,5 +1,5 @@
 /*
  * If not stated otherwise in this file or this component's Licenses.txt file the
  * following copyright and licenses apply:
  *
  * Copyright 2015 RDK Management
@@ -2590,9 +2590,10 @@
     int                             nLast = -1;
 
     /*CID: 74816 Dereference after null check*/
-    if ( pReqArgMatched         || 
-        ulReqArgCount == 0      || 
-        (pReqArgMatched && pReqArgMatched[ulReqArgCount - 1].bMatched && pReqArgMatched[ulReqArgCount - 1].bValueMatched) )
+    if (pReqArgMatched == NULL ||  ulReqArgCount == 0 ||
+	    (pReqArgMatched != NULL &&
+	     pReqArgMatched[ulReqArgCount - 1].bMatched &&
+	     pReqArgMatched[ulReqArgCount - 1].bValueMatched))
     {
         int                         i;
         int                         nMaxTokenPos    = -1;

source/cosa/package/cli/components/ScliShell/scli_shell_process.c

@@ -1,5 +1,5 @@
 /*
  * If not stated otherwise in this file or this component's Licenses.txt file the
  * following copyright and licenses apply:
  *
  * Copyright 2015 RDK Management
@@ -2879,6 +2879,10 @@
                 ScliShoInitArgMatchResult(&pOptArgM[i]);
             }
         }
+	if ( !pReqArgM || !pOptArgM )
+	{
+	    goto EXIT;
+	}
 
         bMatched = 
             ScliShoMatchCommand

source/cosa/package/system/components/SysRepositoryDriver/sys_rdo_access.c

@@ -1,5 +1,5 @@
 /*
  * If not stated otherwise in this file or this component's Licenses.txt file the
  * following copyright and licenses apply:
  *
  * Copyright 2015 RDK Management
@@ -1147,12 +1147,16 @@
 
         goto  EXIT2;
     }
+#if 0
+    /* CID 178124: Logically dead code (DEADCODE)
+    At condition pThisFolder, the value of pThisFolder cannot be NULL */
     else if ( !pThisFolder )
     {
         pThisRecord = (PSYS_REPOSITORY_RECORD_OBJECT)NULL;
 
         goto  EXIT2;
     }
+#endif
     else if ( AnscTcGetTokenCount(pTokenChain) != 1 )
     {
         pThisFolder->ReleaseAccess((ANSC_HANDLE)pThisFolder);
@@ -1318,12 +1322,16 @@
 
         goto  EXIT2;
     }
+#if 0
+    /* CID 178125: Logically dead code (DEADCODE)
+    At condition pThisFolder, the value of pThisFolder cannot be NULL */
     else if ( !pThisFolder )
     {
         returnStatus = ANSC_STATUS_BAD_NAME;
 
         goto  EXIT2;
     }
+#endif
     else if ( AnscTcGetTokenCount(pTokenChain) != 1 )
     {
         pThisFolder->ReleaseAccess((ANSC_HANDLE)pThisFolder);

source/cosa/utilities/bsp_eng/bspeng_co_process.c

@@ -1,5 +1,5 @@
 /*
  * If not stated otherwise in this file or this component's Licenses.txt file the
  * following copyright and licenses apply:
  *
  * Copyright 2015 RDK Management
@@ -808,9 +808,12 @@
 
     if (*pBuf != '/')
         return FALSE;
+#if 0
+    /* CID: 340473: Logically Dead code*/
     else
         if (*pBuf == '\0')
             return FALSE;
+#endif
 
     ch = *(pBuf+1);
 

source/util_api/ansc/AnscPlatform/ansc_checksum.c

@@ -1,5 +1,5 @@
 /*
  * If not stated otherwise in this file or this component's Licenses.txt file the
  * following copyright and licenses apply:
  *
  * Copyright 2015 RDK Management
@@ -130,7 +130,7 @@
         {
             tempUshort++;
             tempUchar += 1;
-            oldLength -= 1;
+	    oldLength = (oldLength > 0) ? (oldLength - 1) : 0;
         }
     }
 
@@ -164,7 +164,7 @@
         {
             tempUshort++;
             tempUchar += 1;
-            newLength -= 1;
+	    newLength = (newLength > 0) ? (newLength - 1) : 0;
         }
     }
 

source/util_api/ansc/AnscPlatform/ansc_task.c

@@ -1,5 +1,5 @@
 /*
  * If not stated otherwise in this file or this component's Licenses.txt file the
  * following copyright and licenses apply:
  *
  * Copyright 2015 RDK Management
@@ -352,7 +352,8 @@
 
         AnscReleaseTask((ANSC_HANDLE)pTaskRecord);
     }
-
+#if 0
+CID: 559697: Unreachable. Above is an infinite loop. So logically Unreachable
     if ( g_bSafeParenting )
     {
         AnscWaitAllChildTasks(pTaskRecord->Handle);
@@ -361,6 +362,7 @@
     AnscEraseTask(pTaskRecord);
 
     AnscLeaveTask();
+#endif
 }
 
 

source/util_api/asn.1/components/asn1_x509/ansc_asn1_certificate.c

@@ -177,38 +177,38 @@ AnscAsn1GenSelfSignedCertificateWithCryptoAPI
 
     if( pPublicKeyInfo != NULL)
     {
-        pPublicKeyInfo->GenerateKey
-            (
-                pPublicKeyInfo,
-                keyType,
-                &genParams
-            );
-    }
-
-    /*
-     *  set the serial number, it supposed to be the MD5 fingerprint of public key 
-     */
-    pInteger       = (PANSC_ASN1_INTEGER)pThisObject->GetSerialNumber(pThisObject);
-    pKeyObject     = (PANSC_ASN1_OBJECT)pPublicKeyInfo->GetExtraChild(pPublicKeyInfo);
-
-    if( pKeyObject != NULL)
-    {
-        if( ANSC_STATUS_SUCCESS == 
-                AnscAsn1GetMD5FingerPrint(pKeyObject, &hash))
-        {
-            /* make it as an unnegative value */
-            if( hash.Value[0] > 0x80)
-            {
-               hash.Value[0] -= 0x80;
-            }
-
-            pInteger->SetStringValue
-                (
-                    pInteger,
-                    hash.Value,
-                    hash.Length
-                );
-        }
+	pPublicKeyInfo->GenerateKey
+	    (
+	     pPublicKeyInfo,
+	     keyType,
+	     &genParams
+	    );
+
+	/*
+	 *  set the serial number, it supposed to be the MD5 fingerprint of public key 
+	 */
+	pInteger       = (PANSC_ASN1_INTEGER)pThisObject->GetSerialNumber(pThisObject);
+	pKeyObject     = (PANSC_ASN1_OBJECT)pPublicKeyInfo->GetExtraChild(pPublicKeyInfo);
+
+	if( pKeyObject != NULL)
+	{
+	    if( ANSC_STATUS_SUCCESS == 
+		    AnscAsn1GetMD5FingerPrint(pKeyObject, &hash))
+	    {
+		/* make it as an unnegative value */
+		if( hash.Value[0] > 0x80)
+		{
+		    hash.Value[0] -= 0x80;
+		}
+
+		pInteger->SetStringValue
+		    (
+		     pInteger,
+		     hash.Value,
+		     hash.Length
+		    );
+	    }
+	}
     }
 
     /*
@@ -306,40 +306,40 @@ AnscAsn1GenerateSelfSignedCertificate
 
     if( pPublicKeyInfo != NULL)
     {
-        pPublicKeyInfo->GenerateKey
-            (
-                pPublicKeyInfo,
-                pAttrObject->KeyType,
-                hKeyPairHandle
-            );
-    }
-
-    /*
-     *  set the serial number, it supposed to be the MD5 fingerprint of public key 
-     */
-    pInteger       = (PANSC_ASN1_INTEGER)pThisObject->GetSerialNumber(pThisObject);
-    pKeyObject     = (PANSC_ASN1_OBJECT)pPublicKeyInfo->GetExtraChild(pPublicKeyInfo);
-
-    if( pKeyObject != NULL)
-    {
-        if( ANSC_STATUS_SUCCESS == 
-                AnscAsn1GetMD5FingerPrint(pKeyObject, &hash))
-        {
-            /* make it as an unnegative value */
-            if( hash.Value[0] > 0x80)
-            {
-               hash.Value[0] -= 0x80;
-            }
+	pPublicKeyInfo->GenerateKey
+	    (
+	     pPublicKeyInfo,
+	     pAttrObject->KeyType,
+	     hKeyPairHandle
+	    );
+
+	/*
+	 *  set the serial number, it supposed to be the MD5 fingerprint of public key 
+	 */
+	pInteger       = (PANSC_ASN1_INTEGER)pThisObject->GetSerialNumber(pThisObject);
+	pKeyObject     = (PANSC_ASN1_OBJECT)pPublicKeyInfo->GetExtraChild(pPublicKeyInfo);
+
+	if( pKeyObject != NULL)
+	{
+	    if( ANSC_STATUS_SUCCESS == 
+		    AnscAsn1GetMD5FingerPrint(pKeyObject, &hash))
+	    {
+		/* make it as an unnegative value */
+		if( hash.Value[0] > 0x80)
+		{
+		    hash.Value[0] -= 0x80;
+		}
+
+		pInteger->SetStringValue
+		    (
+		     pInteger,
+		     hash.Value,
+		     hash.Length
+		    );
+	    }
+	}
 
-            pInteger->SetStringValue
-                (
-                    pInteger,
-                    hash.Value,
-                    hash.Length
-                );
-        }
     }
-
     /*
      *  If subKeyIden extension is required;
      */