RDKB-63270 Test migration from non dhcp-manager to dhcp manager scena…

[vpriya623]

…rio.

Added a line in RdkWanManager.service file to check for the script before
to execute

[Copilot]

Pull request overview

This PR adds support for testing migration scenarios from non-DHCP-manager to DHCP-manager configurations by conditionally executing a PSM value check script during the WAN Manager service startup.

Changes:

• Added a pre-start check in RdkWanManager.service that conditionally executes DHCPMgrPSMValueCheck.sh if the script exists and is executable

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[S-Parthiban-Selvaraj]

This needs to be done for all interfaces (and their virtual interfaces). The current script only operates on the first interface, which means it won’t address scenarios such as a second WAN interface (WANoE).
We can keep the virtual interface count hardcoded to 1 for now (since we don’t currently have devices with multiple virtual interfaces), but the script must loop through all interfaces.

Please check dmsb.wanmanager.wan.interfacecount and iterate all dmsb.wanmanager.if.%d

[vpriya623]

Done the changes

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[rdkcmf-jenkins]

b'## Copyright scan failure
Commit: 2c362ab
Report detail: https://gist.github.com/rdkcmf-jenkins/e5660598f95252e36437cec3947945ba'

[rdkcmf-jenkins]

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

• Protex Server Path: /home/blackduck/github/common-library/87/rdkb/components/opensource/ccsp/CcspCommonLibrary

• Commit: 2c362ab

Report detail: gist'

[mhughesacn]

Hi @vpriya623 : If this file is correctly attributes to DT, please append a credit to top-level NOTICE as follows:

Copyright 2024 Deutsche Telekom AG.
Licensed under the Apache License, Version 2.0

Otherwise, use Comcast (or RDK if written by RDK)

Thank you

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The range validation logic has a subtle issue. The condition [ "$wanifcount" -lt 1 ] || [ "$wanifcount" -gt 10 ] will exit if the count is less than 1 OR greater than 10, which is correct. However, the use of || with && in a single line can be confusing. Consider rewriting this for clarity as: if [ "$wanifcount" -lt 1 ] || [ "$wanifcount" -gt 10 ]; then echo_t "[DHCP Manager PSM Check] wan interface count is out of range" >> $LOG_FILE; exit 1; fi

This makes the logic more explicit and easier to understand.

Suggested change

	[ "$wanifcount" -lt 1 ] || [ "$wanifcount" -gt 10 ] && { echo_t "[DHCP Manager PSM Check] wan interface count is out of range" >> $LOG_FILE; exit 1; }
	if [ "$wanifcount" -lt 1 ] || [ "$wanifcount" -gt 10 ]; then
	echo_t "[DHCP Manager PSM Check] wan interface count is out of range" >> $LOG_FILE
	exit 1
	fi