Skip to content

Comments

RDKEMW-13417: Add Privacy Control check for crashupload [RFC API]#35

Open
gomathishankar37 wants to merge 8 commits intodevelopfrom
topic/privacy-control
Open

RDKEMW-13417: Add Privacy Control check for crashupload [RFC API]#35
gomathishankar37 wants to merge 8 commits intodevelopfrom
topic/privacy-control

Conversation

@gomathishankar37
Copy link
Contributor

No description provided.

@gomathishankar37 gomathishankar37 requested a review from a team as a code owner February 3, 2026 11:31
Copilot AI review requested due to automatic review settings February 3, 2026 11:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request implements privacy control checking for crash upload functionality, allowing users to opt out of crash data sharing through an RFC-based privacy mode setting. The implementation changes the privacy_mode field from a boolean to a string-based enum to support multiple privacy states ("SHARE" vs "DO_NOT_SHARE").

Changes:

  • Adds RFC-based privacy control mode retrieval with default "SHARE" value
  • Implements privacy checks at two points: during dump archiving and before upload process
  • Restricts privacy control checks to MEDIACLIENT devices only

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
c_sourcecode/common/types.h Changes privacy_mode from bool to char[16] array to store string values
c_sourcecode/src/rfcInterface/rfcinterface.h Adds RFC_PRIVACY_MODE constant definition for RFC parameter key
c_sourcecode/src/config/config_manager.h Adds get_privacy_control_mode function declaration
c_sourcecode/src/config/config_manager.c Implements privacy mode initialization with "SHARE" default and RFC reading logic
c_sourcecode/src/main.c Adds privacy control checks: RFC read for MEDIACLIENT devices, skip archiving and upload when DO_NOT_SHARE

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings February 3, 2026 15:02
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@gomathishankar37 gomathishankar37 changed the title Add Privacy Control check for crashupload RDKEMW-13417: Add Privacy Control check for crashupload Feb 4, 2026
@gomathishankar37 gomathishankar37 changed the title RDKEMW-13417: Add Privacy Control check for crashupload RDKEMW-13417: Add Privacy Control check for crashupload [RFC API] Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant