RDKEMW-13417: Add Privacy Control check for crashupload [RFC API]#35
RDKEMW-13417: Add Privacy Control check for crashupload [RFC API]#35gomathishankar37 wants to merge 8 commits intodevelopfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request implements privacy control checking for crash upload functionality, allowing users to opt out of crash data sharing through an RFC-based privacy mode setting. The implementation changes the privacy_mode field from a boolean to a string-based enum to support multiple privacy states ("SHARE" vs "DO_NOT_SHARE").
Changes:
- Adds RFC-based privacy control mode retrieval with default "SHARE" value
- Implements privacy checks at two points: during dump archiving and before upload process
- Restricts privacy control checks to MEDIACLIENT devices only
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| c_sourcecode/common/types.h | Changes privacy_mode from bool to char[16] array to store string values |
| c_sourcecode/src/rfcInterface/rfcinterface.h | Adds RFC_PRIVACY_MODE constant definition for RFC parameter key |
| c_sourcecode/src/config/config_manager.h | Adds get_privacy_control_mode function declaration |
| c_sourcecode/src/config/config_manager.c | Implements privacy mode initialization with "SHARE" default and RFC reading logic |
| c_sourcecode/src/main.c | Adds privacy control checks: RFC read for MEDIACLIENT devices, skip archiving and upload when DO_NOT_SHARE |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: ssahu777 <satyasundar_sahu@comcast.com>
This reverts commit 069ffb9.
Revert "Rebase"
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.