Closed
Conversation
Migrated script to C code
There was a problem hiding this comment.
Pull request overview
This pull request implements Release 2.0.1 of the crashupload component, which adds privacy control functionality via RBUS API, improves logging for error conditions, and updates documentation. The release builds upon version 2.0.0's migration to compiled C code from shell scripts.
Changes:
- Added RBUS-based privacy control mode checking for mediaclient devices to respect user privacy settings
- Changed ERROR-level logs to INFO-level for non-critical failures (directory not open, prerequisites check failed)
- Added comprehensive unit test coverage for RBUS stub functions and privacy mode functionality
- Updated documentation with architecture diagrams and README improvements
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| uploadDumps.sh | Renamed legacy crashuploader flag file from .c_crashupload to .legacy_crashuploader for clarity |
| unittest/utils_gtest.cpp | Updated cleanup_batch test calls to include new do_not_share_cleanup parameter |
| unittest/mainapp_gmock.cpp | Added mock support for get_privacy_control_mode() function and updated cleanup_batch mock signature |
| unittest/config_manager_mock.cpp | Simplified crashupload_log mock implementation |
| unittest/config_manager_gtest.cpp | Added 16 new test cases for privacy mode, RBUS stubs, and RFC interface coverage |
| unittest/Makefile.am | Added rbus_interface.c to config_manager_gtest build sources |
| docs/migration/diagrams/flowcharts/crashupload-binary-architecture.md | New comprehensive architecture documentation with diagrams and system overview |
| c_sourcecode/src/utils/prerequisites.c | Downgraded "dir not open" log from ERROR to INFO level; minor wording fix |
| c_sourcecode/src/utils/cleanup_batch.h | Added do_not_share_cleanup parameter to cleanup_batch function signature |
| c_sourcecode/src/utils/cleanup_batch.c | Implemented DO_NOT_SHARE cleanup logic to delete unprocessed dumps |
| c_sourcecode/src/rfcInterface/rfcinterface.h | Removed unused RFC_TELEMETRY_OPTOUT macro |
| c_sourcecode/src/rbusInterface/rbus_interface.h | New RBUS interface header for TR-181 parameter access |
| c_sourcecode/src/rbusInterface/rbus_interface.c | New RBUS implementation with stub fallback when API not enabled |
| c_sourcecode/src/main.c | Integrated privacy mode checking for mediaclient devices with skip logic for DO_NOT_SHARE |
| c_sourcecode/src/config/config_manager.h | Added get_privacy_control_mode() function declaration |
| c_sourcecode/src/config/config_manager.c | Implemented get_privacy_control_mode() with RBUS integration and safe defaults |
| c_sourcecode/src/Makefile.am | Added RBUS interface files and -lrbus, -lrfcapi linker flags |
| c_sourcecode/common/types.h | Added privacy_control_t enum and changed privacy_mode field type in config_t |
| README.md | New comprehensive README with features, architecture, building, testing, and troubleshooting |
| CHANGELOG.md | Updated changelog for 2.0.1 release with pull request references |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.