Skip to content

Comments

RDKEMW-6149: Implementation of IARM libds event notification APIs (#121)#146

Merged
hgfell683 merged 1 commit intofeature/RDKEMW-7496from
develop
Sep 16, 2025
Merged

RDKEMW-6149: Implementation of IARM libds event notification APIs (#121)#146
hgfell683 merged 1 commit intofeature/RDKEMW-7496from
develop

Conversation

@hgfell683
Copy link
Contributor

  • RDKEMW-6161 devicesettings interface changes

  • wip

  • pc build done

  • remove power event listener

  • added .clang-format

  • Revert "wip"

This reverts commit f9d38b7.

  • remove unused Display Connection Change Listener

  • script to build devicesettings alone

  • remove unused OnSleepModeChanged

  • Video implementation

  • major refactoring

  • self review

  • cov_build.sh cleanup

  • dtor to clean up CallbackList

  • minor cleanup before stating audio

  • added implementation for IAudioPortEvents

  • revert / clean up audioOutputPort

  • make dispatch private

  • copilot review rework

  • clean up audioOutputPort

  • some more cleanupgit add .

  • some more cleanupgit status

  • some more cleanup!!

  • treat all c string to be null terminated

error handling will require more work & buggy

  • avoid templates for dispatch handling

templates would have been fine too, but then I was not able to enable static compilation erorr, without that new devs could get confused. Moreover there are limited callback lists and specialization was required anyway.

  • better indentation

  • some more documentation

  • some more documentation

  • revert some interface changes

  • some rename, remove OnAudioLevelChangedEvent

  • restore OnAudioLevelChanged, implement OnZoomSettingsChanged

  • improv error handling

  • Revert "pc build done"

This reverts commit b1d3e6f.

  • revert compositeIn interface changes

  • revert pc build

  • minor undo pcbuild

  • remove unused header

  • fix full stack build error (fix full stack build error #109)

  • fix full stack build error

  • rename some IARMGroup to maintain consistency

  • minor review comment

  • renaming for consistency

  • implement OnDisplayHDMIHotPlug event

  • minor rename

  • fix typo

  • implement a pending TODO (Video Out OnHDCPStatusChange)

  • avoid redundant type aliases

  • IARMGroupHdmiIn changes added

  • fix incorrect merge

  • topic/RDKEMW6161- Composite and Display Implementation Changes

  • topic/RDKEMW6161- Composite and Display Implementation: Native Build error fix and Coverty fix

  • topic/RDKEMW6161- Composite and Display Implementation: Remove Native fix

  • topic/RDKEMW6161- Composite and Display Implementation: Error Fix and Coverty Fix

  • hdmi-in implementation

  • hdmi-in copilot comments

  • hdmi-in copilot comments1

  • to trigger nav build to user branch

  • temporarily enable native builds for feature branches

  • resolve all compiler warnings

-Wall -Wextra -Wpedantic -Wconversion -Wshadow -Wnull-dereference -Wold-style-cast -Woverloaded-virtual -Wnon-virtual-dtor -Wsign-conversion -Wunused -Wdouble-promotion -Wformat=2 -Wcast-qual -Wcast-align -Wuseless-cast -Wlogical-op -Wmissing-include-dirs -Wredundant-decls -Wundef -Wodr -Wduplicated-cond -Wduplicated-branches

  • minor indentation changes

  • topic/RDKEMW6161- Comments Update and Warning Fix

  • continue1

  • topic/RDKEMW6161- Update Error Fix

  • topic/RDKEMW6161- Update copilot Fix

  • minor: indentation changes

  • implement mutex per callabacklist

  • associate clientName with notification listener

  • prepend IarmHostImpl scope

  • minor: resolve compilation error

  • redefine dsAudioPortState_t, but then control visibility

  • fixing hdmi in warnings

  • name changed to Hdmi

  • fix full stack build failure

  • minor fix, after rebasing to latest

  • improve logging in libds

  • minor fixes

  • fix minor compile error

  • fix minor compile error

  • Ensure buffer is null-terminated if snprintf fails

  • Copilot review comment suggesting wrong fix

  • remove OnDisplayHDCPStatus() from IDisplayEvents

  • rename IarmHostImpl => IarmImpl

  • topic/RDKEMW6161- Comments Updated

  • topic/RDKEMW6161- Copilot fix for Updated Comments

  • compile time enable / disable INT_DEBUG logs

  • LOG_LEVEL => DS_LOG_LEVEL in comments

  • avoid unused compiler warnings.

  • clean up unsupported apis

  • Revert "clean up unsupported apis"

This reverts commit b6828d2.

  • Revert "avoid unused compiler warnings."

This reverts commit 5490cb4.

  • vnsprintf / snprintf both take care of null termination

  • more idiomatic nop

  • remove unused const


* RDKEMW-6161 devicesettings interface changes

* wip

* pc build done

* remove power event listener

* added .clang-format

* Revert "wip"

This reverts commit f9d38b7.

* remove unused Display Connection Change Listener

* script to build devicesettings alone

* remove unused OnSleepModeChanged

* Video implementation

* major refactoring

* self review

* cov_build.sh cleanup

* dtor to clean up CallbackList

* minor cleanup before stating audio

* added implementation for IAudioPortEvents

* revert / clean up audioOutputPort

* make dispatch private

* copilot review rework

* clean up audioOutputPort

* some more cleanupgit add .

* some more cleanupgit status

* some more cleanup!!

* treat all c string to be null terminated

error handling will require more work & buggy

* avoid templates for dispatch handling

templates would have been fine too, but then I was not able to enable
static compilation erorr, without that new devs could get confused.
Moreover there are limited callback lists and specialization was
required anyway.

* better indentation

* some more documentation

* some more documentation

* revert some interface changes

* some rename, remove OnAudioLevelChangedEvent

* restore OnAudioLevelChanged, implement OnZoomSettingsChanged

* improv error handling

* Revert "pc build done"

This reverts commit b1d3e6f.

* revert compositeIn interface changes

* revert pc build

* minor undo pcbuild

* remove unused header

* fix full stack build error (#109)

* fix full stack build error
* rename some IARMGroup to maintain consistency
* minor review comment
* renaming for consistency

* implement OnDisplayHDMIHotPlug event

* minor rename

* fix typo

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* implement a pending TODO (Video Out OnHDCPStatusChange)

* avoid redundant type aliases

* IARMGroupHdmiIn changes added

* fix incorrect merge

* topic/RDKEMW6161- Composite and Display Implementation Changes

* topic/RDKEMW6161- Composite and Display Implementation: Native Build error fix and Coverty fix

* topic/RDKEMW6161- Composite and Display Implementation: Remove Native fix

* topic/RDKEMW6161- Composite and Display Implementation: Error Fix and Coverty Fix

* hdmi-in implementation

* hdmi-in copilot comments

* hdmi-in copilot comments1

* to trigger nav build to user branch

* temporarily enable native builds for feature branches

* resolve all compiler warnings

-Wall -Wextra -Wpedantic -Wconversion -Wshadow -Wnull-dereference
-Wold-style-cast -Woverloaded-virtual -Wnon-virtual-dtor
-Wsign-conversion -Wunused -Wdouble-promotion -Wformat=2 -Wcast-qual
-Wcast-align -Wuseless-cast -Wlogical-op -Wmissing-include-dirs
-Wredundant-decls -Wundef -Wodr -Wduplicated-cond -Wduplicated-branches

* minor indentation changes

* topic/RDKEMW6161- Comments Update and Warning Fix

* continue1

* topic/RDKEMW6161- Update Error Fix

* topic/RDKEMW6161- Update copilot Fix

* minor: indentation changes

* implement mutex per callabacklist

* associate clientName with notification listener

* prepend IarmHostImpl scope

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* minor: resolve compilation error

* redefine dsAudioPortState_t, but then control visibility

* fixing hdmi in warnings

* name changed to Hdmi

* fix full stack build failure

* minor fix, after rebasing to latest

* improve logging in libds

* minor fixes

* fix minor compile error

* fix minor compile error

* Ensure buffer is null-terminated if snprintf fails

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Copilot review comment suggesting wrong fix

* remove OnDisplayHDCPStatus() from IDisplayEvents

* rename IarmHostImpl => IarmImpl

* topic/RDKEMW6161- Comments Updated

* topic/RDKEMW6161- Copilot fix for Updated Comments

* compile time enable / disable INT_DEBUG logs

* LOG_LEVEL => DS_LOG_LEVEL in comments

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* avoid unused compiler warnings.

* clean up unsupported apis

* Revert "clean up unsupported apis"

This reverts commit b6828d2.

* Revert "avoid unused compiler warnings."

This reverts commit 5490cb4.

* vnsprintf / snprintf both take care of null termination

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* more idiomatic nop

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* remove unused const

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: kkaliyaperumal <kkaliyaperumal@synamedia.com>
Co-authored-by: Ramesh Babu H <rababu2@synamedia.com>
Co-authored-by: karuppaiyak <120160434+karuppaiyak@users.noreply.github.com>
@hgfell683 hgfell683 requested a review from a team as a code owner September 16, 2025 15:00
@hgfell683 hgfell683 requested a review from a team September 16, 2025 15:00
@hgfell683 hgfell683 merged commit 3a2868d into feature/RDKEMW-7496 Sep 16, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants