RDKEMW-12054: Fix Coverity identified issues#190
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Coverity static analysis issues across multiple files, focusing on format specifier corrections, member initialization, and resource management improvements.
Key Changes:
- Fixed printf format specifiers for proper type handling (intptr_t, size_t, uint32_t, bool)
- Added member initialization in constructors to prevent uninitialized variables
- Improved exception handling and resource cleanup in test application
- Fixed thread synchronization in audio manager termination
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sample/testFrontPanel.cpp | Restructured exception handling and added resource cleanup for early exit path |
| rpc/srv/dsAudio.c | Fixed bool format specifier and thread-safe termination with proper locking |
| rpc/cli/dsVideoPort.c | Corrected format specifiers for intptr_t and size_t types |
| ds/videoDevice.cpp | Added member initialization for _dfc in constructor |
| ds/include/exception.hpp | Added _err member initialization in single-parameter constructor |
| ds/hdmiIn.cpp | Fixed format specifier for sizeof() result |
| ds/audioOutputPort.cpp | Corrected format specifiers for intptr_t and uint32_t types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Added initialization flag to manage resource cleanup on exceptions.
Removed default case handling for switch statements in EDID parser.
apatel859
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change: Fixed the Coverity identified issues
Risks: Low
Priority: P2
Signed-off-by:Dineshkumar P [dinesh_kumar2@comcast.com]