Skip to content

Comments

RDKEVD-5910:HALIF header 4.1.2.#214

Open
Pothiraj-Paul wants to merge 1 commit intodevelopfrom
feature/RDKEVD-5910
Open

RDKEVD-5910:HALIF header 4.1.2.#214
Pothiraj-Paul wants to merge 1 commit intodevelopfrom
feature/RDKEVD-5910

Conversation

@Pothiraj-Paul
Copy link

Reason for change:Inclusion of HALIF latest version.
Test Procedure:Build and verify.

Reason for change:Inclusion of HALIF latest version.
Test Procedure:Build and verify.
@Pothiraj-Paul Pothiraj-Paul requested a review from a team as a code owner February 19, 2026 12:14
Copilot AI review requested due to automatic review settings February 19, 2026 12:14
@Pothiraj-Paul Pothiraj-Paul self-assigned this Feb 19, 2026
@github-actions
Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates device settings’ frame-rate mappings to align with the latest HALIF header version (4.1.2), extending the internal ID→value/name tables used by FrameRate.

Changes:

  • Added new frame rate entries (59, 23) to the internal _values and _names lookup arrays.
  • Expanded the supported frame-rate list to match the (presumably updated) dsVIDEO_FRAMERATE_MAX size expectation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 51 to +55
200,
239.79,
240,
59,
23,
Copy link

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The frame rate value for the 239.xx entry is inconsistent across the repo: ds/frameRate.cpp uses 239.79/"239.79", but ds/hdmiIn.cpp maps dsVIDEO_FRAMERATE_239dot76 to "239.76". Please verify which value HALIF defines for this enum and make the float/string consistent (likely 239.76) so IDs map to the correct displayed value.

Copilot uses AI. Check for mistakes.
Comment on lines +54 to +55
59,
23,
Copy link

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New entries in the _values array use inconsistent indentation (mixed tabs/spaces) compared to surrounding entries, which hurts readability and can cause noisy diffs. Please align these lines with the existing formatting in this initializer list.

Copilot uses AI. Check for mistakes.
Comment on lines +73 to +74
"59",
"23",
Copy link

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since _values/names are indexed directly by the dsVideoFrameRate_t ID, adding new numeric entries at the end is fragile unless the HALIF enum values are guaranteed to be appended in the same order. To prevent mismatches, add explicit trailing comments indicating the corresponding dsVIDEO_FRAMERATE* constant for each new entry (or otherwise document/verify the ordering) so future HALIF updates don’t silently break the mapping.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant