Conversation
Reason for change:Inclusion of HALIF latest version. Test Procedure:Build and verify.
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
There was a problem hiding this comment.
Pull request overview
Updates device settings’ frame-rate mappings to align with the latest HALIF header version (4.1.2), extending the internal ID→value/name tables used by FrameRate.
Changes:
- Added new frame rate entries (
59,23) to the internal_valuesand_nameslookup arrays. - Expanded the supported frame-rate list to match the (presumably updated)
dsVIDEO_FRAMERATE_MAXsize expectation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| 200, | ||
| 239.79, | ||
| 240, | ||
| 59, | ||
| 23, |
There was a problem hiding this comment.
The frame rate value for the 239.xx entry is inconsistent across the repo: ds/frameRate.cpp uses 239.79/"239.79", but ds/hdmiIn.cpp maps dsVIDEO_FRAMERATE_239dot76 to "239.76". Please verify which value HALIF defines for this enum and make the float/string consistent (likely 239.76) so IDs map to the correct displayed value.
| 59, | ||
| 23, |
There was a problem hiding this comment.
New entries in the _values array use inconsistent indentation (mixed tabs/spaces) compared to surrounding entries, which hurts readability and can cause noisy diffs. Please align these lines with the existing formatting in this initializer list.
| "59", | ||
| "23", |
There was a problem hiding this comment.
Since _values/names are indexed directly by the dsVideoFrameRate_t ID, adding new numeric entries at the end is fragile unless the HALIF enum values are guaranteed to be appended in the same order. To prevent mismatches, add explicit trailing comments indicating the corresponding dsVIDEO_FRAMERATE* constant for each new entry (or otherwise document/verify the ordering) so future HALIF updates don’t silently break the mapping.
Reason for change:Inclusion of HALIF latest version.
Test Procedure:Build and verify.