Skip to content

Comments

RDKEMW-4621: L1 test for Xcast plugin#121

Open
yuvaramachandran-gurusamy wants to merge 58 commits intodevelopfrom
topic/RDKEMW-4621_Xcast
Open

RDKEMW-4621: L1 test for Xcast plugin#121
yuvaramachandran-gurusamy wants to merge 58 commits intodevelopfrom
topic/RDKEMW-4621_Xcast

Conversation

@yuvaramachandran-gurusamy
Copy link
Contributor

@yuvaramachandran-gurusamy yuvaramachandran-gurusamy commented Aug 24, 2025

RDKEMW-4621: L1 test for Xcast plugin

Signed-off-by: yuvaramachandran_gurusamy yuvaramachandran_gurusamy@comcast.com

@yuvaramachandran-gurusamy
RDKEMW-4621: L1 test for Xcast plugin
b790dbf 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy yuvaramachandran-gurusamy requested a review from a team as a code owner August 24, 2025 17:28
yuvaramachandran-gurusamy and others added 27 commits August 24, 2025 23:29
@yuvaramachandran-gurusamy
RDKEMW-4621: Use custom branch for validation
31cfc92
@yuvaramachandran-gurusamy
RDKEMW-4621: Fix L1 test failures
a61062a 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Merge branch 'topic/RDKEMW-4621_Xcast' of github.com:rdkcentral/entse…
327f60a 
…rvices-casting into topic/RDKEMW-4621_Xcast
@yuvaramachandran-gurusamy
RDKEMW-4621: Fix build errors
e58c8f1 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
RDKEMW-4621: Fix Build failures
0788722 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Fix build errors
7723e7c 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Enable GDB
b873db0 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Use dispatcherImplMock
5b3fc24 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Test
f55e23f 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
dispatcherImplMock build error fix
5304b6e 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Added trace logs
a6a7e70 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Add logic
74247ad 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Logs
edabd94 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Test
8790394 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Adding Trace logs
15eb912 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Adding debugs
d8e13a0 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Trace prints
91d482d 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Add debugs
61574e0 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Test
bd85359 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Integrate NetworkManager
6f09b99 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Test
a17d035 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Test
8066aeb 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Fix build Error
7a9e119 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Test
faf4625 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Test
036443c 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Fix errors
348087e 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Test
98a19b9 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
rdkcmf-jenkins
rdkcmf-jenkins reviewed Sep 8, 2025
View reviewed changes
XCast/XCastImplementation.h Outdated
void onIPAddressChange(const string interface, const string ipversion, const string ipaddress, const Exchange::INetworkManager::IPStatus status) override
{
LOGINFO("IP Address changed: Interface [%s] IP Version [%s] Address [%s] Status [%d]", interface.c_str(), ipversion.c_str(), ipaddress.c_str(), status);
_parent.onIPAddressChange(interface, ipversion, ipaddress, status);
Copy link
Contributor

@rdkcmf-jenkins rdkcmf-jenkins Sep 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Variable copied when it could be moved

"interface" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""interface"")" instead of "interface".

XCast/XCastImplementation.h Outdated
void onIPAddressChange(const string interface, const string ipversion, const string ipaddress, const Exchange::INetworkManager::IPStatus status) override
{
LOGINFO("IP Address changed: Interface [%s] IP Version [%s] Address [%s] Status [%d]", interface.c_str(), ipversion.c_str(), ipaddress.c_str(), status);
_parent.onIPAddressChange(interface, ipversion, ipaddress, status);
Copy link
Contributor

@rdkcmf-jenkins rdkcmf-jenkins Sep 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Variable copied when it could be moved

"ipaddress" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""ipaddress"")" instead of "ipaddress".

XCast/XCastImplementation.h Outdated
void onActiveInterfaceChange(const string prevActiveInterface, const string currentActiveinterface) override
{
LOGINFO("Active interface changed [%s] -- > [%s]",prevActiveInterface.c_str(), currentActiveinterface.c_str());
_parent.onActiveInterfaceChange(prevActiveInterface, currentActiveinterface);
Copy link
Contributor

@rdkcmf-jenkins rdkcmf-jenkins Sep 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Variable copied when it could be moved

"currentActiveinterface" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""currentActiveinterface"")" instead of "currentActiveinterface".

XCast/XCastImplementation.h Outdated
void onIPAddressChange(const string interface, const string ipversion, const string ipaddress, const Exchange::INetworkManager::IPStatus status) override
{
LOGINFO("IP Address changed: Interface [%s] IP Version [%s] Address [%s] Status [%d]", interface.c_str(), ipversion.c_str(), ipaddress.c_str(), status);
_parent.onIPAddressChange(interface, ipversion, ipaddress, status);
Copy link
Contributor

@rdkcmf-jenkins rdkcmf-jenkins Sep 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Variable copied when it could be moved

"ipversion" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""ipversion"")" instead of "ipversion".

XCast/XCastImplementation.h Outdated
void onActiveInterfaceChange(const string prevActiveInterface, const string currentActiveinterface) override
{
LOGINFO("Active interface changed [%s] -- > [%s]",prevActiveInterface.c_str(), currentActiveinterface.c_str());
_parent.onActiveInterfaceChange(prevActiveInterface, currentActiveinterface);
Copy link
Contributor

@rdkcmf-jenkins rdkcmf-jenkins Sep 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Variable copied when it could be moved

"prevActiveInterface" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""prevActiveInterface"")" instead of "prevActiveInterface".

Tests/L1Tests/tests/test_XCast.cpp
PluginHost::IFactories::Assign(&factoriesImplementation);
Core::IWorkerPool::Assign(&(*workerPool));
workerPool->Run();
}
Copy link
Contributor

@rdkcmf-jenkins rdkcmf-jenkins Sep 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Uninitialized pointer field

Non-static class member "dispatcher" is not initialized in this constructor nor in any functions that it calls.

Medium Impact, CWE-457
UNINIT_CTOR

@yuvaramachandran-gurusamy
Event test
cc2eb76 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Test
695e430 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Test
8052989 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Disable unRegisterAllApplications Test
556a2d7 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Event update
8598eae 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Test
1d44b02 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Test
cbe156e 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Fix Testcase
95ee560 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Fix testcase failures
f946052 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Test
3398843 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Test
b76ac7b 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Test
f41694e 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Test
351d7d6 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Test
15303cc 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Test
3255f68 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Test
cbdc2ba 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Testcase
642c7a9 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Test
52acc29 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
RegisterApplication test
c7b035a 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Fix error
6c0a57b 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Fix testcase
bef299c 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Test
f02eef4 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Final
ce63ed2 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Testing
be55945 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Test
a805895 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Testing
9d89749 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Merge pull request #127 from rdkcentral/develop
28b11a5 
Rebase with Develop branch
@rdkcmf-jenkins
Copy link
Contributor

rdkcmf-jenkins commented Sep 12, 2025

Coverity Issue - Uninitialized pointer field

Non-static class member "mConfigure" is not initialized in this constructor nor in any functions that it calls.

Medium Impact, CWE-457
UNINIT_CTOR

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
XCast/XCast.cpp:52

@yuvaramachandran-gurusamy
Fixing Coverity issues
1b89037 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Test
8863010 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rdkcmf-jenkins rdkcmf-jenkins rdkcmf-jenkins left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yuvaramachandran-gurusamy @rdkcmf-jenkins