Skip to content

Conversation

@tomasz-blasz
Copy link
Contributor

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the CMake build configuration to extract version detection logic into a reusable module and updates the semantic-release configuration to support RC (release candidate) branches.

  • Extracts version detection logic from CMakeLists.txt into a separate cmake/version.cmake module
  • Updates release branch configuration from "next" to RC branches matching the pattern +([0-9]).+([0-9])-rc
  • Modifies the maintenance branch configuration to use a more complex range expression

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
cmake/version.cmake New module containing version detection logic using Git tags, fallback to .version file, and version component parsing
CMakeLists.txt Removes inline version detection code and includes the new version.cmake module; updates status message to show both project and transport versions
.releaserc.json Changes prerelease branch from "next" to RC pattern, reorders and updates maintenance branch configuration fields
.github/workflows/release.yml Updates workflow condition to trigger on RC branches instead of "next" branch

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tomasz-blasz tomasz-blasz force-pushed the topic/build-keep-build-dir branch from 36f199f to 6fb506e Compare December 19, 2025 15:29
@tomasz-blasz tomasz-blasz merged commit 8d45059 into main Dec 19, 2025
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2025
@tomasz-blasz tomasz-blasz deleted the topic/build-keep-build-dir branch December 19, 2025 16:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants