test: fix coverity RESOURCE_LEAK in rbusTestProvider (v2)#409
Open
svc-rdkeportal01 wants to merge 2 commits intodevelopfrom
Open
test: fix coverity RESOURCE_LEAK in rbusTestProvider (v2)#409svc-rdkeportal01 wants to merge 2 commits intodevelopfrom
svc-rdkeportal01 wants to merge 2 commits intodevelopfrom
Conversation
Fixes Coverity CID 106, 107 Generated by RDKDevPilot AI Bot (v2) Root Cause: Resource leak when createTableNode/createPropertyNode fail. rowNode not freed on error. Changes: - Add error checking in addTable2RowHandler (CID 106) - Add error checking in addTable1RowHandler (CID 107) - Cleanup rowNode on failure Supersedes: PR #391 Bot Score: 95/100
The function destroyTableRowNode does not exist. Use destroyNode with cast instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Coverity RESOURCE_LEAK in rbusTestProvider
Improved fix with enhanced bot validation. Supersedes PR #391.
Coverity Issues
This PR fixes two RESOURCE_LEAK issues:
addTable2RowHandleraddTable1RowHandlerRoot Cause
Resource leak occurs when
createTableRowNode()successfully allocates aTableRowNode, but subsequent calls tocreateTableNode()orcreatePropertyNode()fail. The allocatedrowNodeis not freed, causing a memory leak.Changes
addTable2RowHandler (CID 106):
createTableNode()resultcreatePropertyNode()resultdestroyNode()and return error on failureaddTable1RowHandler (CID 107):
createTableNode()resultcreatePropertyNode()resultdestroyNode()and return error on failureImpact
✅ Prevents memory leak when node creation fails
✅ Proper error handling with cleanup
✅ Returns appropriate error code (
RBUS_ERROR_OUT_OF_RESOURCES)Supersedes: #391