rbus: fixup null returns in getEventTableInstNum#415
Open
svc-rdkeportal01 wants to merge 1 commit intodevelopfrom
Open
rbus: fixup null returns in getEventTableInstNum#415svc-rdkeportal01 wants to merge 1 commit intodevelopfrom
svc-rdkeportal01 wants to merge 1 commit intodevelopfrom
Conversation
Coverity issue ID: 85 (line 1337) Fix generated by RDKDevPilot AI Bot Co-authored-by: rdkdevpilot <bot@rdkcentral.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix NULL_RETURNS in getEventTableInstNum
Issues Fixed
test/rbus/provider/rbusTestProvider.cat line 1337Root Cause
strstr()can return NULL if the substring "EventsTable." is not found in the input string. The original code adds 12 to the result without checking for NULL, then immediately dereferences it, which can cause a segmentation fault.Changes Made
Added NULL check before using the pointer returned by
strstr():Before:
After: