RDK-60607: Coverity fix for y2k38_issue by dshett549 · Pull Request #441 · rdkcentral/rbus

dshett549 · 2026-02-19T14:32:18Z

Reason For Change: y2k38 issue
Signed-off-by: Deepthi DEEPTHICHANDRASHEKAR_SHETTY@comcast.com

Signed-off-by: dshett549 <DEEPTHICHANDRASHEKAR_SHETTY@comcast.com>

Copilot

Pull request overview

This PR addresses the Year 2038 (Y2K38) problem by converting timestamp fields from 32-bit (time_t/int32_t) to 64-bit (uint64_t) types. The Y2K38 issue occurs when 32-bit signed time_t values overflow on January 19, 2038. This change ensures the codebase can handle timestamps beyond 2038.

Changes:

Converted timestamp fields T1-T5 in rtMessageHeader from time_t to uint64_t with corresponding encoding/decoding updates
Changed buffer size tracking fields (bytes_read, bytes_to_read, read_buffer_capacity) from int to uint64_t to support larger buffer sizes
Added new rtMessage_SetUInt64/GetUInt64 API functions and rtEncoder_EncodeUInt64/DecodeUInt64 encoding functions for 64-bit unsigned integer support

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
src/rtmessage/rtMessageHeader.h	Changed T1-T5 timestamp fields from time_t to uint64_t
src/rtmessage/rtMessageHeader.c	Updated header size calculation and encoding/decoding to use UInt64 functions, added inttypes.h include
src/rtmessage/rtEncoder.h	Added declarations for rtEncoder_EncodeUInt64 and rtEncoder_DecodeUInt64
src/rtmessage/rtEncoder.c	Implemented 64-bit encoding/decoding functions using htobe64/be64toh
src/rtmessage/rtMessage.h	Added rtMessage_SetUInt64 and rtMessage_GetUInt64 API declarations
src/rtmessage/rtMessage.c	Implemented uint64_t message functions using string serialization with PRIu64/strtoull, added inttypes.h include
src/rtmessage/rtConnection.c	Updated timestamp assignments with uint64_t casts and changed rtConnection_SendInternal signature
src/rtmessage/rtrouteBase.h	Changed bytes_read, bytes_to_read, read_buffer_capacity from int to uint64_t
src/rtmessage/rtrouteBase.c	Updated timestamp assignments with uint64_t casts, changed format specifiers to %ld, fixed local variable type
src/rtmessage/rtrouted.c	Updated message handling to use GetUInt64/SetUInt64, changed format specifiers to %ld, fixed local variable type

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-19T14:38:02Z

src/rtmessage/rtrouted.c

          else
          {
-            rtLog_Info("Couldn't not reallocate read buffer to accommodate %d bytes. Message will be dropped.", incoming_data_size);
+            rtLog_Info("Couldn't not reallocate read buffer to accommodate %ld bytes. Message will be dropped.", incoming_data_size);


Double negative "Couldn't not" should be corrected to "Couldn't" or "Could not". This is a grammatical error that makes the message confusing.

Suggested change

rtLog_Info("Couldn't not reallocate read buffer to accommodate %ld bytes. Message will be dropped.", incoming_data_size);

rtLog_Info("Could not reallocate read buffer to accommodate %ld bytes. Message will be dropped.", incoming_data_size);

Copilot · 2026-02-19T14:38:03Z

src/rtmessage/rtrouteBase.c

          else
          {
-            rtLog_Info("Couldn't not reallocate read buffer to accommodate %d bytes. Message will be dropped.", incoming_data_size);
+            rtLog_Info("Couldn't not reallocate read buffer to accommodate %ld bytes. Message will be dropped.", incoming_data_size);


Double negative "Couldn't not" should be corrected to "Couldn't" or "Could not". This is a grammatical error that makes the message confusing.

Suggested change

rtLog_Info("Couldn't not reallocate read buffer to accommodate %ld bytes. Message will be dropped.", incoming_data_size);

rtLog_Info("Couldn't reallocate read buffer to accommodate %ld bytes. Message will be dropped.", incoming_data_size);

Copilot · 2026-02-19T14:38:03Z

src/rtmessage/rtrouted.c

            clnt->read_buffer = ptr;
            clnt->read_buffer_capacity = incoming_data_size;
-            rtLog_Info("Reallocated read buffer to %d bytes to accommodate traffic.", incoming_data_size);
+            rtLog_Info("Reallocated read buffer to %ld bytes to accommodate traffic.", incoming_data_size);


Using %ld format specifier for uint64_t is not portable across all platforms. On 32-bit systems, uint64_t may require %llu, while on 64-bit systems %ld may work but is technically incorrect. The proper portable format specifier for uint64_t is PRIu64 from inttypes.h. Note that rtMessageHeader.c already includes inttypes.h and uses PRIu64 correctly.

Copilot · 2026-02-19T14:38:03Z

src/rtmessage/rtrouted.c

          else
          {
-            rtLog_Info("Couldn't not reallocate read buffer to accommodate %d bytes. Message will be dropped.", incoming_data_size);
+            rtLog_Info("Couldn't not reallocate read buffer to accommodate %ld bytes. Message will be dropped.", incoming_data_size);


Using %ld format specifier for uint64_t is not portable across all platforms. On 32-bit systems, uint64_t may require %llu, while on 64-bit systems %ld may work but is technically incorrect. The proper portable format specifier for uint64_t is PRIu64 from inttypes.h. Note that rtMessageHeader.c already includes inttypes.h and uses PRIu64 correctly.

Copilot · 2026-02-19T14:38:04Z

src/rtmessage/rtrouteBase.c

            clnt->read_buffer = ptr;
            clnt->read_buffer_capacity = incoming_data_size;
-            rtLog_Info("Reallocated read buffer to %d bytes to accommodate traffic.", incoming_data_size);
+            rtLog_Info("Reallocated read buffer to %ld bytes to accommodate traffic.", incoming_data_size);


Using %ld format specifier for uint64_t is not portable across all platforms. On 32-bit systems, uint64_t may require %llu, while on 64-bit systems %ld may work but is technically incorrect. The proper portable format specifier for uint64_t is PRIu64 from inttypes.h. Note that rtMessageHeader.c already includes inttypes.h and uses PRIu64 correctly.

Copilot · 2026-02-19T14:38:04Z

src/rtmessage/rtrouted.c

        clnt->bytes_to_read += clnt->header.payload_length;
        clnt->state = rtConnectionState_ReadPayload;
-        int incoming_data_size = clnt->bytes_to_read + clnt->bytes_read;
+        uint64_t incoming_data_size = clnt->bytes_to_read + clnt->bytes_read;


Potential integer overflow when adding clnt->bytes_to_read and clnt->bytes_read. Since both are now uint64_t, the sum could theoretically overflow, though this is extremely unlikely in practice. However, since this value is used with rt_try_realloc which typically expects size_t, and since memory allocation will fail for extremely large values anyway, the code should validate that incoming_data_size does not exceed reasonable bounds before attempting reallocation.

Copilot · 2026-02-19T14:38:04Z

src/rtmessage/rtrouteBase.h

+  uint64_t                      bytes_read;
+  uint64_t                       bytes_to_read;
+  uint64_t                       read_buffer_capacity;


The spacing/indentation for these three uint64_t fields is inconsistent. The type declaration should align properly with other fields in the struct for better readability and code consistency. Compare with the consistent spacing used for other fields like "int fd" and "rtConnectionState state".

Suggested change

uint64_t bytes_read;

uint64_t bytes_to_read;

uint64_t read_buffer_capacity;

uint64_t bytes_read;

uint64_t bytes_to_read;

uint64_t read_buffer_capacity;

Copilot · 2026-02-19T14:38:05Z

src/rtmessage/rtrouteBase.c

          else
          {
-            rtLog_Info("Couldn't not reallocate read buffer to accommodate %d bytes. Message will be dropped.", incoming_data_size);
+            rtLog_Info("Couldn't not reallocate read buffer to accommodate %ld bytes. Message will be dropped.", incoming_data_size);


Using %ld format specifier for uint64_t is not portable across all platforms. On 32-bit systems, uint64_t may require %llu, while on 64-bit systems %ld may work but is technically incorrect. The proper portable format specifier for uint64_t is PRIu64 from inttypes.h. Note that rtMessageHeader.c already includes inttypes.h and uses PRIu64 correctly.

Copilot · 2026-02-19T14:38:05Z

src/rtmessage/rtrouteBase.c

        clnt->bytes_to_read += clnt->header.payload_length;
        clnt->state = rtConnectionState_ReadPayload;
-        int incoming_data_size = clnt->bytes_to_read + clnt->bytes_read;
+        uint64_t incoming_data_size = clnt->bytes_to_read + clnt->bytes_read;


Potential integer overflow when adding clnt->bytes_to_read and clnt->bytes_read. Since both are now uint64_t, the sum could theoretically overflow, though this is extremely unlikely in practice. However, since this value is used with rt_try_realloc which typically expects size_t, and since memory allocation will fail for extremely large values anyway, the code should validate that incoming_data_size does not exceed reasonable bounds before attempting reallocation.

Copilot · 2026-02-19T14:38:05Z

src/rtmessage/rtMessage.c

+    cJSON* p = cJSON_GetObjectItem(message->json, name);
+    if (p && p->valuestring)
+    {
+        *value = strtoull(p->valuestring, NULL, 10);


The strtoull function is called without error checking. If the string cannot be converted to a valid uint64_t (e.g., contains non-numeric characters, overflows), strtoull will return 0 or ULLONG_MAX and set errno, but this code doesn't check for these error conditions. Consider using the second parameter (endptr) to verify that the entire string was consumed, or check errno after the call to detect conversion errors.

rdkcmf-jenkins · 2026-02-19T14:45:31Z

Coverity Issue - Unchecked return value

Calling "pthread_mutexattr_init" without checking return value (as is done elsewhere 8 out of 10 times).

Medium Impact, CWE-252
CHECKED_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
src/rtmessage/rtConnection.c:531

rdkcmf-jenkins · 2026-02-19T14:45:31Z

Coverity Issue - Overflowed integer argument

The cast of "msginfo->header.payload_length" to a signed type could result in a negative number.

High Impact, CWE-190
INTEGER_OVERFLOW

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
src/rtmessage/rtConnection.c:1612

karuna2git · 2026-02-19T18:06:24Z

src/rtmessage/rtConnection.c

  if(header.flags & rtMessageFlags_Request)
  {
-       header.T1 = send_time.tv_sec;
+       header.T1 = (uint64_t)send_time.tv_sec;


(uint64_t)send_time.tv_sec * 1000000000LL + ts.tv_nsec; This way we could retain the nanosec details too.

karuna2git · 2026-02-19T18:06:37Z

src/rtmessage/rtConnection.c

       header.T2 = T2;
       header.T3 = T3;
-       header.T4 = send_time.tv_sec;
+       header.T4 = (uint64_t)send_time.tv_sec;


same as above

gladish · 2026-02-23T20:12:03Z

Any idea on how this will work with #435?

dshett549 · 2026-02-24T02:12:51Z

Closing this PR, as it is handled in other PR 442

Coverity fix for y2k38_issue

2385c31

Signed-off-by: dshett549 <DEEPTHICHANDRASHEKAR_SHETTY@comcast.com>

Copilot AI review requested due to automatic review settings February 19, 2026 14:32

dshett549 requested a review from a team as a code owner February 19, 2026 14:32

Copilot started reviewing on behalf of dshett549 February 19, 2026 14:32 View session

dshett549 changed the title ~~Coverity fix for y2k38_issue~~ RDK-60607: Coverity fix for y2k38_issue Feb 19, 2026

Copilot AI reviewed Feb 19, 2026

View reviewed changes

Merge branch 'develop' into topic/RDK-60607_y2k38

1781df1

karuna2git requested changes Feb 19, 2026

View reviewed changes

dshett549 closed this Feb 24, 2026

github-actions bot locked and limited conversation to collaborators Feb 24, 2026

	rtLog_Info("Couldn't not reallocate read buffer to accommodate %ld bytes. Message will be dropped.", incoming_data_size);
	rtLog_Info("Could not reallocate read buffer to accommodate %ld bytes. Message will be dropped.", incoming_data_size);

	rtLog_Info("Couldn't not reallocate read buffer to accommodate %ld bytes. Message will be dropped.", incoming_data_size);
	rtLog_Info("Couldn't reallocate read buffer to accommodate %ld bytes. Message will be dropped.", incoming_data_size);

Comments

Conversation

dshett549 commented Feb 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

rdkcmf-jenkins commented Feb 19, 2026

Coverity Issue - Unchecked return value

Issue location

Uh oh!

rdkcmf-jenkins commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverity Issue - Overflowed integer argument

Issue location

Uh oh!

karuna2git Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

karuna2git Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

gladish commented Feb 23, 2026

Uh oh!

dshett549 commented Feb 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rdkcmf-jenkins commented Feb 19, 2026 •

edited

Loading