Skip to content

Comments

Add unit tests for RDKLOG_FORMAT_WITH_TID and RDKLOG_FORMAT_WITH_TS_TID formats#51

Closed
Copilot wants to merge 4 commits intotopic/LogHugeDatafrom
copilot/sub-pr-49-again
Closed

Add unit tests for RDKLOG_FORMAT_WITH_TID and RDKLOG_FORMAT_WITH_TS_TID formats#51
Copilot wants to merge 4 commits intotopic/LogHugeDatafrom
copilot/sub-pr-49-again

Conversation

Copy link

Copilot AI commented Feb 20, 2026

Adds test coverage for the RDKLOG_FORMAT_WITH_TID and RDKLOG_FORMAT_WITH_TS_TID log formats, which were previously untested in the rotation test suite.

Changes

  • FormatWithTID test: Verifies log rotation behavior with thread ID format
  • FormatWithTSTID test: Verifies log rotation behavior with timestamp + thread ID format
  • Both tests follow existing patterns from RDKLOG_FORMAT_WITH_TS tests, validating:
    • Successful logger initialization with the format
    • Correct file rotation on size limit breach
    • File count limits are enforced
TEST_F(RDKLoggerRotationTest, FormatWithTID) {
    RUN_IN_FORK({
        rdk_LogOutput_File testPolicy;
        // ... configure policy ...
        config.format = RDKLOG_FORMAT_WITH_TID;
        rdk_Error ret = rdk_logger_ext_init(&config);
        ASSERT_EQ(ret, RDK_SUCCESS);
        // ... verify rotation behavior ...
    });
}

Also added .gitignore for autotools build artifacts.


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Copilot AI and others added 3 commits February 20, 2026 02:02
Co-authored-by: karuna2git <48997923+karuna2git@users.noreply.github.com>
Co-authored-by: karuna2git <48997923+karuna2git@users.noreply.github.com>
Co-authored-by: karuna2git <48997923+karuna2git@users.noreply.github.com>
Copilot AI changed the title [WIP] Add unit tests for RDKLOG_FORMAT_WITH_TS_TID and RDKLOG_FORMAT_WITH_TID Add unit tests for RDKLOG_FORMAT_WITH_TID and RDKLOG_FORMAT_WITH_TS_TID formats Feb 20, 2026
Copilot AI requested a review from karuna2git February 20, 2026 02:04
@karuna2git karuna2git force-pushed the topic/LogHugeData branch 4 times, most recently from 394f064 to a3d3a69 Compare February 22, 2026 05:51
@karuna2git karuna2git deleted the branch topic/LogHugeData February 22, 2026 06:01
@karuna2git karuna2git closed this Feb 22, 2026
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants