Conversation
|
Pull request must be merged with a description containing the required fields, Summary: If there is no jira releated to this change, please put 'Jira: NO-JIRA'. Description can be changed by editing the top comment on your pull request and making a new commit. |
|
build-rpi4-ipstb-oss Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/f12a68a60ecb12789c0e33ff705b88f4 |
|
build-brcm-refboard3 Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/7ba7f532033362b9151044d034d0196e |
|
build-brcm-refboard3 Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/4e99af527d523f5526c88a90a105d89e |
|
build-rpi4-ipstb-oss Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/2f7c42ee7a5ed54185788fb96ce2cfbc |
|
build-rpi4-ipstb-oss Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/e5e0d3214137ca2b53afe3a21b70c122 |
|
build-brcm-refboard3 Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/fc75923570e1cdde9f386fa779b46bb5 |
|
build-brcm-refboard3 Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/792edcd94ad39655e877780e0c96c6d4 |
|
build-rpi4-ipstb-oss Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/5f81df87c08afdaf6b789c3207f0dafa |
|
Sanity tests for ['RPI4 IPSTB'] added. |
|
Sanity tests for ['BCM 7216OTT Refboard VA'] added. |
|
build-rpi4-ipstb-oss Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/f1eb1349aec35f736db4e8fc382d9e99 |
|
build-brcm-refboard3 Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/a7bb5bdd5a2adb68506fd7d289b6ba9f |
|
Job for |
|
Job for |
|
Job for |
|
Job for |
|
Job for |
| SynchroniseSubtitleClock::SynchroniseSubtitleClock(GenericPlayerContext &context, IGstGenericPlayerPrivate &player, | ||
| std::shared_ptr<firebolt::rialto::wrappers::IGstWrapper> gstWrapper, | ||
| std::shared_ptr<firebolt::rialto::wrappers::IGlibWrapper> glibWrapper) | ||
| : m_context{context}, m_player{player}, m_gstWrapper{gstWrapper}, m_glibWrapper{glibWrapper} |
There was a problem hiding this comment.
Coverity Issue - Variable copied when it could be moved
"glibWrapper" is passed-by-value as parameter to "std::shared_ptrfirebolt::rialto::wrappers::IGlibWrapper::shared_ptr(std::shared_ptrfirebolt::rialto::wrappers::IGlibWrapper const &) /explicit =default/", when it could be moved instead.
Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE
How to fix
Use "std::move(""glibWrapper"")" instead of "glibWrapper".
| SynchroniseSubtitleClock::SynchroniseSubtitleClock(GenericPlayerContext &context, IGstGenericPlayerPrivate &player, | ||
| std::shared_ptr<firebolt::rialto::wrappers::IGstWrapper> gstWrapper, | ||
| std::shared_ptr<firebolt::rialto::wrappers::IGlibWrapper> glibWrapper) | ||
| : m_context{context}, m_player{player}, m_gstWrapper{gstWrapper}, m_glibWrapper{glibWrapper} |
There was a problem hiding this comment.
Coverity Issue - Variable copied when it could be moved
"gstWrapper" is passed-by-value as parameter to "std::shared_ptrfirebolt::rialto::wrappers::IGstWrapper::shared_ptr(std::shared_ptrfirebolt::rialto::wrappers::IGstWrapper const &) /explicit =default/", when it could be moved instead.
Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE
How to fix
Use "std::move(""gstWrapper"")" instead of "gstWrapper".
|
Job for |
|
nofile:0:0: information: Unmatched suppression: unusedFunction [unmatchedSuppression] nofile:0:0: information: Active checkers: 161/592 (use --checkers-report= to see details) [checkersReport] |
|
Job for |
|
nofile:0:0: information: Unmatched suppression: unusedFunction [unmatchedSuppression] nofile:0:0: information: Active checkers: 161/592 (use --checkers-report= to see details) [checkersReport] |
3 participants
No description provided.