RDKEMW-5331: Add log redirection specification before launching container #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nhanasi
approved these changes
Sep 25, 2025
Contributor
nhanasi
left a comment
nhanasi
left a comment
There was a problem hiding this comment.
Please do proper test to ensure no breakage to existing logic,
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
shibu-kv
requested changes
Sep 30, 2025
| mkdir -p "$LogFilePathPerm/$APP_LOG" | ||
| backupLog "Move logs from $LOG_PATH to $LogFilePathPerm" | ||
| find "$LOG_PATH" -maxdepth 1 -mindepth 1 \( -type l -o -type f \) \( -iname "*.txt*" -o -iname "*.log*" -o -name "bootlog" \) -exec mv '{}' "$LogFilePathPerm" \; | ||
| find "$APP_LOG_PATH" -maxdepth 1 -mindepth 1 \( -type l -o -type f \) \( -iname "*.txt*" -o -iname "*.log*" \) -exec mv '{}' "$LogFilePathPerm/$APP_LOG" \; |
Contributor
There was a problem hiding this comment.
This is not just about backup. A new sub directory in logs is not in alignment with the systems architecture. This also means that we will also loose capabilities to get telemetry insights.
Log monitoring, upload and other systems dealing with logging also might need to be thoughtfully revisisted.
This change cannot be taken in without involving system architects.
sajilal711
force-pushed
the
topic/RDKEMW-5331
branch
from
3b9bd1c to
79f9297
Compare
sajilal711
force-pushed
the
topic/RDKEMW-5331
branch
from
79f9297 to
9644fdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifed the backup_log file to handle the directory available if its not exist and backup the apps log as well.