RDKEMW-10439: Reboot device with WareHouse plugin resetDevice #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arun-madhavan-013
approved these changes
Dec 1, 2025
Contributor
arun-madhavan-013
left a comment
arun-madhavan-013
left a comment
There was a problem hiding this comment.
Wpeframework warehouse plugin is invoking this script and stopping parent process will cause this script execution to stop abruptly.
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the factory reset operation fails when triggered via the Warehouse plugin API (org.rdk.Warehouse.1.resetDevice). The issue occurs because the Warehouse plugin runs within wpeframework.service, and stopping this service during the reset kills the process executing the API call.
Key Changes
- Removed the explicit stop of
wpeframework.servicefrom the factory reset script - Aligns factory-reset.sh behavior with warehouse-reset.sh, which already follows this pattern
- Allows the Warehouse plugin API to complete the reset operation successfully
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue - Factory reset not working with API - "org.rdk.Warehouse.1.resetDevice"