Topic/otel tr69hostif by dharshini555 · Pull Request #330 · rdkcentral/tr69hostif

dharshini555 · 2025-12-23T12:15:39Z

No description provided.

rdkcmf-jenkins · 2025-12-23T12:30:46Z

Coverity Issue - Missing return statement

Arriving at the end of a function without returning a value.

High Impact, CWE-710
MISSING_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
src/unittest/stubs/iarm_stubs.cpp:156

rdkcmf-jenkins · 2025-12-23T12:30:46Z

Coverity Issue - Missing return statement

Arriving at the end of a function without returning a value.

High Impact, CWE-710
MISSING_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
src/unittest/stubs/iarm_stubs.cpp:145

rdkcmf-jenkins · 2025-12-23T12:30:46Z

Coverity Issue - Missing return statement

Arriving at the end of a function without returning a value.

High Impact, CWE-710
MISSING_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
src/unittest/stubs/iarm_stubs.cpp:166

rdkcmf-jenkins · 2025-12-23T12:30:46Z

Coverity Issue - Missing return statement

Arriving at the end of a function without returning a value.

High Impact, CWE-710
MISSING_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
src/unittest/stubs/iarm_stubs.cpp:148

rdkcmf-jenkins · 2025-12-23T12:30:46Z

Coverity Issue - Missing return statement

Arriving at the end of a function without returning a value.

High Impact, CWE-710
MISSING_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
src/unittest/stubs/iarm_stubs.cpp:139

rdkcmf-jenkins · 2025-12-23T12:30:46Z

Coverity Issue - Array compared against 0

Comparing an array to null is not useful: ""Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.Power.DeepSleepNotification.Enable" != NULL", since the test will always evaluate as true.

Medium Impact, CWE-398
NO_EFFECT

How to fix

Was ""Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.Power.DeepSleepNotification.Enable"" formerly declared as a pointer?

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
src/hostif/handlers/src/hostIf_IARM_ReqHandler.cpp:622

rdkcmf-jenkins · 2025-12-23T12:30:46Z

Coverity Issue - Missing return statement

Arriving at the end of a function without returning a value.

High Impact, CWE-710
MISSING_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
src/unittest/stubs/iarm_stubs.cpp:173

rdkcmf-jenkins · 2025-12-23T12:30:46Z

Coverity Issue - Missing return statement

Arriving at the end of a function without returning a value.

High Impact, CWE-710
MISSING_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
src/unittest/stubs/iarm_stubs.cpp:142

rdkcmf-jenkins · 2025-12-23T12:30:46Z

Coverity Issue - Missing return statement

Arriving at the end of a function without returning a value.

High Impact, CWE-710
MISSING_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
src/unittest/stubs/iarm_stubs.cpp:152

rdkcmf-jenkins · 2025-12-23T12:30:46Z

Coverity Issue - Missing return statement

Arriving at the end of a function without returning a value.

High Impact, CWE-710
MISSING_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
src/unittest/stubs/iarm_stubs.cpp:162

rdkcmf-jenkins · 2025-12-23T12:30:46Z

src/hostif/handlers/src/hostIf_IARM_ReqHandler.cpp

+        cout << "[hostIf_SetReqHandler] Hex dump of trace_id field: ";
+        unsigned char* ptr = (unsigned char*)stMsgData->trace_id;
+        for (int i = 0; i < 40; i++) {
+            cout << std::hex << std::setw(2) << std::setfill('0') << (int)ptr[i] << " ";


Coverity Issue - Out-of-bounds read

Overrunning array of 33 bytes at byte offset 39 by dereferencing pointer "ptr + i".

High Impact, CWE-125
OVERRUN

rdkcmf-jenkins · 2025-12-23T12:30:46Z

src/hostif/handlers/tr69hostif_otlp_instrumentation.cpp

+ * Supports distributed tracing with W3C Trace Context
+ */
+//trace libs
+#include <opentelemetry/trace/provider.h>


Coverity Issue - Unrecoverable parse warning

cannot open source file "opentelemetry/trace/provider.h"

Low Impact, CWE-none
PARSE_ERROR

rdkcmf-jenkins · 2025-12-23T12:30:46Z

src/hostif/handlers/src/hostIf_IARM_ReqHandler.cpp

+        cout << "[hostIf_SetReqHandler] Hex dump of trace_id field: ";
+        unsigned char* ptr = (unsigned char*)stMsgData->trace_id;
+        for (int i = 0; i < 40; i++) {
+            cout << std::hex << std::setw(2) << std::setfill('0') << (int)ptr[i] << " ";


Coverity Issue - Out-of-bounds read

Overrunning array of 33 bytes at byte offset 39 by dereferencing pointer "ptr + i".

High Impact, CWE-125
OVERRUN

rdkcmf-jenkins · 2025-12-23T12:30:47Z

src/hostif/handlers/tr69hostif_otlp_instrumentation.cpp

+ * Supports distributed tracing with W3C Trace Context
+ */
+//trace libs
+#include <opentelemetry/trace/provider.h>


Coverity Issue - Unrecoverable parse warning

cannot open source file "opentelemetry/trace/provider.h"

Low Impact, CWE-none
PARSE_ERROR

rdkcmf-jenkins · 2025-12-23T12:30:47Z

Coverity Issue - Missing return statement

Arriving at the end of a function without returning a value.

High Impact, CWE-710
MISSING_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
src/unittest/stubs/iarm_stubs.cpp:152

rdkcmf-jenkins · 2025-12-23T12:30:47Z

Coverity Issue - Missing return statement

Arriving at the end of a function without returning a value.

High Impact, CWE-710
MISSING_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
src/unittest/stubs/iarm_stubs.cpp:142

rdkcmf-jenkins · 2025-12-23T12:30:47Z

Coverity Issue - Missing return statement

Arriving at the end of a function without returning a value.

High Impact, CWE-710
MISSING_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
src/unittest/stubs/iarm_stubs.cpp:145

rdkcmf-jenkins · 2025-12-23T12:30:47Z

Coverity Issue - Missing return statement

Arriving at the end of a function without returning a value.

High Impact, CWE-710
MISSING_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
src/unittest/stubs/iarm_stubs.cpp:173

rdkcmf-jenkins · 2025-12-23T12:30:47Z

Coverity Issue - Missing return statement

Arriving at the end of a function without returning a value.

High Impact, CWE-710
MISSING_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
src/unittest/stubs/iarm_stubs.cpp:166

rdkcmf-jenkins · 2025-12-23T12:30:47Z

Coverity Issue - Missing return statement

Arriving at the end of a function without returning a value.

High Impact, CWE-710
MISSING_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
src/unittest/stubs/iarm_stubs.cpp:148

rdkcmf-jenkins · 2025-12-23T12:30:47Z

Coverity Issue - Missing return statement

Arriving at the end of a function without returning a value.

High Impact, CWE-710
MISSING_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
src/unittest/stubs/iarm_stubs.cpp:139

rdkcmf-jenkins · 2025-12-23T12:30:47Z

Coverity Issue - Array compared against 0

Comparing an array to null is not useful: ""Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.Power.DeepSleepNotification.Enable" != NULL", since the test will always evaluate as true.

Medium Impact, CWE-398
NO_EFFECT

How to fix

Was ""Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.Power.DeepSleepNotification.Enable"" formerly declared as a pointer?

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
src/hostif/handlers/src/hostIf_IARM_ReqHandler.cpp:622

rdkcmf-jenkins · 2025-12-23T12:30:47Z

Coverity Issue - Missing return statement

Arriving at the end of a function without returning a value.

High Impact, CWE-710
MISSING_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
src/unittest/stubs/iarm_stubs.cpp:162

rdkcmf-jenkins · 2025-12-23T14:58:14Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/tr69hostif/330/rdk/components/generic/tr69hostif
Commit: cb50abc

Report detail: gist'

rdkcmf-jenkins · 2025-12-23T14:59:03Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/tr69hostif/330/rdk/components/generic/tr69hostif
Commit: cb50abc

Report detail: gist'

rdkcmf-jenkins · 2025-12-23T16:10:17Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/tr69hostif/330/rdk/components/generic/tr69hostif
Commit: cb50abc

Report detail: gist'

mhughesacn · 2025-12-29T21:14:15Z

src/hostif/handlers/include/tr69hostif_otlp_instrumentation.h

@@ -0,0 +1,85 @@
+/**
+ * OpenTelemetry OTLP HTTP Instrumentation Header for TR69HostIF
+ * C-compatible interface for tracing TR69HostIF operations with distributed tracing support


Cleared off the code match in the tool as boilerplate, but this file should have an RDK apache header if it is indeed original RDK/Comcast content.

dharshini555 added 12 commits November 11, 2025 11:55

Add openTelemetry traces support for tr69hostif

7dd6a6d

Add instrumentation cpp file

97de1fa

Add metrics support for tr69hostif

92a715a

Instrument metrics

31475db

Instrument metrics

735cced

Instrument metrics

1d46eb1

Update cppflags for xione build

325cc2c

Update Makefile.am files

93ad254

Update tr69hostif instrumentation changes

5bae932

Update Distributed tracing

272b4a4

Add instrumenatation changes to send the traces to laptop

4423076

Resolve build errors

4b77223

dharshini555 requested a review from a team as a code owner December 23, 2025 12:15

Update cov_build.sh

cb50abc

rdkcmf-jenkins reviewed Dec 23, 2025

View reviewed changes

mhughesacn reviewed Dec 29, 2025

View reviewed changes

Comments

Conversation

dharshini555 commented Dec 23, 2025

Uh oh!

rdkcmf-jenkins commented Dec 23, 2025

Coverity Issue - Missing return statement

Issue location

Uh oh!

rdkcmf-jenkins commented Dec 23, 2025

Coverity Issue - Missing return statement

Issue location

Uh oh!

rdkcmf-jenkins commented Dec 23, 2025

Coverity Issue - Missing return statement

Issue location

Uh oh!

rdkcmf-jenkins commented Dec 23, 2025

Coverity Issue - Missing return statement

Issue location

Uh oh!

rdkcmf-jenkins commented Dec 23, 2025

Coverity Issue - Missing return statement

Issue location

Uh oh!

rdkcmf-jenkins commented Dec 23, 2025

Coverity Issue - Array compared against 0

How to fix

Issue location

Uh oh!

rdkcmf-jenkins commented Dec 23, 2025

Coverity Issue - Missing return statement

Issue location

Uh oh!

rdkcmf-jenkins commented Dec 23, 2025

Coverity Issue - Missing return statement

Issue location

Uh oh!

rdkcmf-jenkins commented Dec 23, 2025

Coverity Issue - Missing return statement

Issue location

Uh oh!

rdkcmf-jenkins commented Dec 23, 2025

Coverity Issue - Missing return statement

Issue location

Uh oh!

rdkcmf-jenkins Dec 23, 2025

Choose a reason for hiding this comment

Coverity Issue - Out-of-bounds read

Uh oh!

rdkcmf-jenkins Dec 23, 2025

Choose a reason for hiding this comment

Coverity Issue - Unrecoverable parse warning

Uh oh!

rdkcmf-jenkins Dec 23, 2025

Choose a reason for hiding this comment

Coverity Issue - Out-of-bounds read

Uh oh!

rdkcmf-jenkins Dec 23, 2025

Choose a reason for hiding this comment

Coverity Issue - Unrecoverable parse warning

Uh oh!

rdkcmf-jenkins commented Dec 23, 2025

Coverity Issue - Missing return statement

Issue location

Uh oh!

rdkcmf-jenkins commented Dec 23, 2025

Coverity Issue - Missing return statement

Issue location

Uh oh!

rdkcmf-jenkins commented Dec 23, 2025

Coverity Issue - Missing return statement

Issue location

Uh oh!

rdkcmf-jenkins commented Dec 23, 2025

Coverity Issue - Missing return statement

Issue location

Uh oh!

rdkcmf-jenkins commented Dec 23, 2025

Coverity Issue - Missing return statement

Issue location