RDKCOM-5508: RDKBDEV-3356 IPQ Bug Fixes for QCOM Platform#183
RDKCOM-5508: RDKBDEV-3356 IPQ Bug Fixes for QCOM Platform#183VedhaLoganathan wants to merge 1 commit intordkcentral:developfrom
Conversation
VedhaLoganathan
changed the title
| { | ||
| printf("Partner ID NOT Found\n"); | ||
| sprintf(PartnerID,"%s","unknown"); | ||
| snprintf(PartnerID,sizeof(PartnerID),"%s","unknown"); |
There was a problem hiding this comment.
PartnerID is a char * parameter, so sizeof(PartnerID) returns the size of the pointer (typically 4 bytes), not the buffer size. This will cause a problem when PartnerID string length is greater then 4 bytes. Similar type of code changes are done in other places please fix the review comments and resubmit for review.
If you really need length of the buffer, you may need to pass buffer length as additional parameter to the function validatePartnerId(char *partnerId, size_t partnerIdBufLen).
pradeeptakdas
left a comment
pradeeptakdas
left a comment
There was a problem hiding this comment.
Please check the review comments
pradeeptakdas
changed the title
VedhaLoganathan
force-pushed
the
ipq_upstream3
branch
from
b5b4fdc to
1b9bfbb
Compare
|
@VedhaLoganathan |
VedhaLoganathan
force-pushed
the
ipq_upstream3
branch
from
1b9bfbb to
ca09819
Compare
|
Hi @tinaelizabeth84, |
| if [ "$noRf" = "0" ] | ||
| then | ||
| if [ "$NETWORKRESPONSESTATUS" = "204" ] && [ "$REDIRECTION_ON" = "true" ] && [ "$WIFI_NOT_CONFIGURED" = "true" ] | ||
| if [[ "$NETWORKRESPONSESTATUS" = "204" && "$REDIRECTION_ON" = "true" && ("$WIFI_NOT_CONFIGURED" = "true" || "$WIFI_NOT_CONFIGURED" = "TRUE") ]]; |
There was a problem hiding this comment.
We can change database value as "true" so that no need to change in script.
There was a problem hiding this comment.
Reverted the changes and handled in database.
| syscfg_get( NULL, "lan_ipaddr", buf, sizeof( buf )); | ||
|
|
||
| if (defaultAdminIP != NULL) | ||
| if ((defaultAdminIP != NULL) && (strcmp(buf, defaultAdminIP) == 0)) |
There was a problem hiding this comment.
What is this change exactly about?
There was a problem hiding this comment.
Previously, the logic only checked whether the DM value (DefaultAdminIP / DefaultLocalIPv4SubnetRange) was non‑NULL. As a result, it would overwrite the customer’s configured LAN IP or netmask with the partner default—for example, replacing a customer‑set 192.168.1.1 with the branding default 10.0.0.1, causing brlan0 to come up with the wrong address.
| syscfg_get( NULL, "lan_netmask", buf, sizeof( buf )); | ||
|
|
||
| if (subnetRange != NULL) | ||
| if ((subnetRange != NULL) && (strcmp(buf, subnetRange) == 0)) |
There was a problem hiding this comment.
What is this change exactly about?
| syscfg_get( NULL, "dhcp_start", buf, sizeof( buf )); | ||
|
|
||
| if (minAddress != NULL) | ||
| if ((minAddress != NULL) && (strcmp(buf, minAddress) ==0)) |
There was a problem hiding this comment.
What is this change exactly about?
| syscfg_get( NULL, "dhcp_end", buf, sizeof( buf )); | ||
|
|
||
| if (maxAddress != NULL) | ||
| if ((maxAddress != NULL) && (strcmp(buf, maxAddress) == 0)) |
There was a problem hiding this comment.
What is this change exactly about?
| if (n < 0 || n >= sizeof(cmd)) | ||
| return -1; | ||
|
|
||
| #ifndef _COSA_QCA_ARM_ |
There was a problem hiding this comment.
Is vsystem() getting called very frequently?
|
Can you please fix the review comments suggested by @hpatel006c ? |
Signed-off-by: Vedhavalli Loganathan <vedhaval@qti.qualcomm.com>
VedhaLoganathan
force-pushed
the
ipq_upstream3
branch
from
ca09819 to
d3d7054
Compare
4 participants
No description provided.