RDKB-63415 : Move SelfHeal Scripts to Cron by aj970-crypto · Pull Request #229 · rdkcentral/utopia

aj970-crypto · 2026-02-18T13:16:36Z

RDKB-63415 : Move SelfHeal Scripts to Cron

Reason for change: Running the Selfheal scripts as cron jobs instead of background processes when the cron is enabled and running as normal background process when the cron is disabled.
Test Procedure: Check scripts are running in crontab when the cron is enabled.
Risks: Low
Priority: P0

Signed-off-by: aj970 <akshaya_j@comcast.com>

Copilot

Pull request overview

This PR updates the cron service startup to schedule SelfHeal-related scripts as cron jobs when SelfHealCronEnable and selfheal_enable are both enabled, and introduces a new default enabling SelfHealCronEnable on ARM targets.

Changes:

Add conditional cron scheduling for selfheal_aggressive.sh, resource_monitor.sh, and self_heal_connectivity_test.sh based on SelfHealCronEnable/selfheal_enable.
Change when syscfg_recover.sh (and currently resource_monitor_recover.sh) is added to the root crontab depending on SelfHeal cron enablement.
Add a new default SelfHealCronEnable=true in ARM system defaults.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
source/scripts/init/service.d/service_crond.sh	Adds conditional SelfHeal cron rules driven by syscfg flags and intervals.
source/scripts/init/defaults/system_defaults_arm	Sets `SelfHealCronEnable` default to true (with a new comment).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-18T13:20:52Z

source/scripts/init/service.d/service_crond.sh

      # Monitor resource_monitor.sh every 5 minutes TCCBR-3288
 #      if [ "$BOX_TYPE" = "TCCBR" ]; then 
         echo "*/5 * * * * /usr/ccsp/tad/resource_monitor_recover.sh" >> $CRONTAB_FILE
 #      fi
+
+      fi


resource_monitor_recover.sh cron entry is now inside the else branch, so it will only run when SelfHealCronEnable/selfheal_enable are not both true. Previously this job ran unconditionally; if it’s still required regardless of SelfHeal cron mode, move it (and its comment) outside the conditional or add it to both branches to avoid losing the recovery behavior when SelfHeal cron is enabled.

Suggested change

# Monitor resource_monitor.sh every 5 minutes TCCBR-3288

# if [ "$BOX_TYPE" = "TCCBR" ]; then

echo "*/5 * * * * /usr/ccsp/tad/resource_monitor_recover.sh" >> $CRONTAB_FILE

# fi

fi

fi

# Monitor resource_monitor.sh every 5 minutes TCCBR-3288

# if [ "$BOX_TYPE" = "TCCBR" ]; then

echo "*/5 * * * * /usr/ccsp/tad/resource_monitor_recover.sh" >> $CRONTAB_FILE

# fi

Copilot · 2026-02-18T13:20:52Z

source/scripts/init/service.d/service_crond.sh

+      SELFHEAL_CRON_ENABLE=$(syscfg get SelfHealCronEnable)
+      SELFHEAL_ENABLE=$(syscfg get selfheal_enable)
+      if [ "$SELFHEAL_CRON_ENABLE" = "true" ] && [ "$SELFHEAL_ENABLE" = "true" ]; then
+	      echo_t "SelfHeal Cron is enabled"
+         # Monitor selfheal_aggressive.sh based on syscfg value
+         AGGRESSIVE_INTERVAL=$(syscfg get AggressiveInterval)
+         if [ -z "$AGGRESSIVE_INTERVAL" ]; then
+            AGGRESSIVE_INTERVAL=5
+         fi
+         #Write cron rule
+         echo "*/$AGGRESSIVE_INTERVAL * * * * /usr/ccsp/tad/selfheal_aggressive.sh" >> $CRONTAB_FILE
+
+	      # Monitor resource_monitor.sh based on syscfg value 
+         RESOURCE_MONITOR_INTERVAL=$(syscfg get resource_monitor_interval)
+         if [ -z "$RESOURCE_MONITOR_INTERVAL" ]; then
+            RESOURCE_MONITOR_INTERVAL=15
+         fi
+         echo "*/$RESOURCE_MONITOR_INTERVAL * * * * /usr/ccsp/tad/resource_monitor.sh" >> $CRONTAB_FILE
+
+        # Monitor self_heal_connectivity_test.sh based on syscfg value 
+         SELFHEAL_PING_INTERVAL=$(syscfg get ConnTest_PingInterval)
+         if [ -z "$SELFHEAL_PING_INTERVAL" ]; then
+            SELFHEAL_PING_INTERVAL=60
+         fi
+         echo "*/$SELFHEAL_PING_INTERVAL * * * * /usr/ccsp/tad/self_heal_connectivity_test.sh" >> $CRONTAB_FILE 
+	      echo_t "Selfheal cron jobs are started"
+
+      else
+	      echo_t "Selfheal cron is disabled"
+	      # Monitor syscfg DB every 15minutes
+         echo "*/15 * * * * /usr/ccsp/tad/syscfg_recover.sh" >> $CRONTAB_FILE


With this change, syscfg_recover.sh is only scheduled when SelfHeal cron is disabled. If monitoring/recovering the syscfg DB is still required when SelfHeal cron is enabled, this is a behavior change from the previous unconditional cron entry. Consider keeping syscfg_recover.sh scheduled in both modes or explicitly replacing that functionality in the enabled branch.

Copilot · 2026-02-18T13:20:53Z

source/scripts/init/defaults/system_defaults_arm

 #Wifi Personalization Support Default value
 $WiFiPersonalizationSupport=true

+#RFC for cron is enabled by default.


The new comment is unclear/grammatically awkward (“RFC for cron is enabled by default.”). Consider rewording to something more specific, e.g., that the SelfHeal cron RFC flag (SelfHealCronEnable) defaults to enabled.

Suggested change

#RFC for cron is enabled by default.

# SelfHeal cron RFC flag (SelfHealCronEnable) is enabled by default.

Copilot · 2026-02-18T13:20:53Z

source/scripts/init/service.d/service_crond.sh

+         AGGRESSIVE_INTERVAL=$(syscfg get AggressiveInterval)
+         if [ -z "$AGGRESSIVE_INTERVAL" ]; then
+            AGGRESSIVE_INTERVAL=5
+         fi
+         #Write cron rule
+         echo "*/$AGGRESSIVE_INTERVAL * * * * /usr/ccsp/tad/selfheal_aggressive.sh" >> $CRONTAB_FILE
+
+	      # Monitor resource_monitor.sh based on syscfg value 
+         RESOURCE_MONITOR_INTERVAL=$(syscfg get resource_monitor_interval)
+         if [ -z "$RESOURCE_MONITOR_INTERVAL" ]; then
+            RESOURCE_MONITOR_INTERVAL=15
+         fi
+         echo "*/$RESOURCE_MONITOR_INTERVAL * * * * /usr/ccsp/tad/resource_monitor.sh" >> $CRONTAB_FILE
+
+        # Monitor self_heal_connectivity_test.sh based on syscfg value 
+         SELFHEAL_PING_INTERVAL=$(syscfg get ConnTest_PingInterval)
+         if [ -z "$SELFHEAL_PING_INTERVAL" ]; then
+            SELFHEAL_PING_INTERVAL=60
+         fi
+         echo "*/$SELFHEAL_PING_INTERVAL * * * * /usr/ccsp/tad/self_heal_connectivity_test.sh" >> $CRONTAB_FILE 


The cron entries for selfheal_aggressive.sh, resource_monitor.sh, and self_heal_connectivity_test.sh are built directly from syscfg values (AggressiveInterval, resource_monitor_interval, ConnTest_PingInterval) without validating that they are numeric, so a malicious value containing spaces or additional fields can inject an arbitrary command into the crontab line and be executed as root. For example, if an attacker can set AggressiveInterval via any remote or untrusted configuration path to include extra cron fields and a custom command, the resulting echoed line will cause cron to run that attacker-controlled command instead of the intended script. Restrict these intervals to a safe numeric range (e.g., via a regex or arithmetic check) before use, and reject or sanitize any value that is not purely numeric to prevent cron injection.

snayak002c · 2026-02-18T23:04:27Z

source/scripts/init/defaults/system_defaults_arm

-$FwDwld_ImageProcMemPercent=0
-
+#RFC for cron is enabled by default.
+$SelfHealCronEnable=true


resolve the merge conflict , also add this to bci and xle system defaults file.

Signed-off-by: aj970 <akshaya_j@comcast.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 11 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-19T06:46:29Z

source/scripts/init/service.d/service_crond.sh

+      SELFHEAL_CRON_ENABLE=$(syscfg get SelfHealCronEnable)
+      SELFHEAL_ENABLE=$(syscfg get selfheal_enable)
+      if [ "$SELFHEAL_CRON_ENABLE" = "true" ] && [ "$SELFHEAL_ENABLE" = "true" ]; then
+	      echo_t "SelfHeal Cron is enabled"


Inconsistent indentation detected. This line uses a tab character at the start, while the surrounding code in this file consistently uses spaces for indentation. The echo_t statements should align with the indentation style used elsewhere in the file, which appears to be 3 spaces for statements inside if blocks.

Copilot · 2026-02-19T06:46:30Z

source/scripts/init/service.d/service_crond.sh

+         fi
+         #Write cron rule
+         echo "*/$AGGRESSIVE_INTERVAL * * * * /usr/ccsp/tad/selfheal_aggressive.sh" >> $CRONTAB_FILE
+


Inconsistent indentation detected. This line uses a tab character, while the surrounding code consistently uses spaces for indentation. The echo statements should align with the indentation style used elsewhere in the file.

Copilot · 2026-02-19T06:46:30Z

source/scripts/init/service.d/service_crond.sh

+            SELFHEAL_PING_INTERVAL=60
+         fi
+         echo "*/$SELFHEAL_PING_INTERVAL * * * * /usr/ccsp/tad/self_heal_connectivity_test.sh" >> $CRONTAB_FILE 
+	      echo_t "Selfheal cron jobs are started"


Inconsistent indentation detected. This line uses a tab character, while the surrounding code consistently uses spaces for indentation. The echo_t statement should align with the indentation style used elsewhere in the file.

Copilot · 2026-02-19T06:46:30Z

source/scripts/init/service.d/service_crond.sh

+            RESOURCE_MONITOR_INTERVAL=15
+         fi
+         echo "*/$RESOURCE_MONITOR_INTERVAL * * * * /usr/ccsp/tad/resource_monitor.sh" >> $CRONTAB_FILE
+


Inconsistent indentation detected. Line 187 uses spaces for indentation but line 188 uses tabs and extra spaces. The echo statement should align with the indentation style used elsewhere in the file, which appears to use spaces consistently.

Suggested change

Copilot · 2026-02-19T06:46:30Z

source/scripts/init/service.d/service_crond.sh

+         fi
+         echo "*/$RESOURCE_MONITOR_INTERVAL * * * * /usr/ccsp/tad/resource_monitor.sh" >> $CRONTAB_FILE
+
+        # Monitor self_heal_connectivity_test.sh based on syscfg value 


Spacing inconsistency in comment. There appears to be extra whitespace after "syscfg value". This comment should have consistent spacing with other similar comments in the block.

Suggested change

# Monitor self_heal_connectivity_test.sh based on syscfg value

# Monitor self_heal_connectivity_test.sh based on syscfg value

Copilot · 2026-02-19T06:46:31Z

source/scripts/init/service.d/service_crond.sh

+	      echo_t "Selfheal cron jobs are started"
+
+      else
+	      echo_t "Selfheal cron is disabled"


Inconsistent indentation detected. This line uses a tab character, while the surrounding code consistently uses spaces for indentation. The echo_t statement should align with the indentation style used elsewhere in the file.

Copilot · 2026-02-19T06:46:31Z

source/scripts/init/service.d/service_crond.sh

+
+      else
+	      echo_t "Selfheal cron is disabled"
+	      # Monitor syscfg DB every 15minutes


Spacing inconsistency in comment. There appears to be extra whitespace after the comment text. This comment should end immediately after "15minutes" without trailing spaces for consistency with other comments in the file.

Copilot · 2026-02-19T06:46:31Z

source/scripts/init/service.d/service_crond.sh

+         #Write cron rule
+         echo "*/$AGGRESSIVE_INTERVAL * * * * /usr/ccsp/tad/selfheal_aggressive.sh" >> $CRONTAB_FILE
+
+	      # Monitor resource_monitor.sh based on syscfg value 


Inconsistent indentation detected. This line uses a tab character, while the surrounding code consistently uses spaces for indentation. Comment lines should follow the same indentation pattern as the rest of the file.

Suggested change

# Monitor resource_monitor.sh based on syscfg value

# Monitor resource_monitor.sh based on syscfg value

Copilot · 2026-02-19T06:46:31Z

source/scripts/init/service.d/service_crond.sh

 #      if [ "$BOX_TYPE" = "TCCBR" ]; then 
         echo "*/5 * * * * /usr/ccsp/tad/resource_monitor_recover.sh" >> $CRONTAB_FILE
 #      fi
+


Inconsistent indentation detected. This line uses a tab character, while the surrounding code consistently uses spaces for indentation. The echo statement should align with the indentation style used elsewhere in the file.

Copilot · 2026-02-19T06:46:31Z

source/scripts/init/service.d/service_crond.sh

+         if [ -z "$SELFHEAL_PING_INTERVAL" ]; then
+            SELFHEAL_PING_INTERVAL=60
+         fi
+         echo "*/$SELFHEAL_PING_INTERVAL * * * * /usr/ccsp/tad/self_heal_connectivity_test.sh" >> $CRONTAB_FILE 


Trailing whitespace detected after the cron rule. The line should end immediately after CRONTAB_FILE without any trailing spaces or tabs, for consistency with other cron entries in the file.

Starting selfheal scripts as cron job when cron is enabled

8933098

Signed-off-by: aj970 <akshaya_j@comcast.com>

Copilot AI review requested due to automatic review settings February 18, 2026 13:16

aj970-crypto requested review from a team as code owners February 18, 2026 13:16

Copilot started reviewing on behalf of aj970-crypto February 18, 2026 13:17 View session

Copilot AI reviewed Feb 18, 2026

View reviewed changes

snayak002c approved these changes Feb 18, 2026

View reviewed changes

snayak002c requested changes Feb 18, 2026

View reviewed changes

aj970-crypto added 2 commits February 19, 2026 11:21

Merge branch 'develop' into feature/RDKB-63415

049da71

Starting selfheal scripts as cron job when cron is enabled

683dba8

Signed-off-by: aj970 <akshaya_j@comcast.com>

Copilot AI review requested due to automatic review settings February 19, 2026 06:39

Copilot started reviewing on behalf of aj970-crypto February 19, 2026 06:39 View session

Copilot AI reviewed Feb 19, 2026

View reviewed changes

snayak002c approved these changes Feb 20, 2026

View reviewed changes

	#RFC for cron is enabled by default.
	# SelfHeal cron RFC flag (SelfHealCronEnable) is enabled by default.

	# Monitor self_heal_connectivity_test.sh based on syscfg value
	# Monitor self_heal_connectivity_test.sh based on syscfg value

	# Monitor resource_monitor.sh based on syscfg value
	# Monitor resource_monitor.sh based on syscfg value

Comments

Conversation

aj970-crypto commented Feb 18, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

snayak002c Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants