Rdkb 63584: srv_unregister remove DHCPManager Distro#234
Merged
hpatel006c merged 3 commits intodevelopfrom Feb 20, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the DHCP Manager distro-specific compile guard in the DHCP server registration helper so that srv_unregister() always unregisters dhcp_server from pmon, aligning unregister behavior with the existing unconditional srv_register() behavior.
Changes:
- Remove the
#if !defined(FEATURE_RDKB_DHCP_MANAGER)guard aroundpmon.sh unregister dhcp_server. - Drop the associated comment about the DHCP Manager self-heal mechanism.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hpatel006c
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rdkb 63584: srv_unregister remove DHCPManager Distro
This PR removes the DHCP Manager distro-specific compile guard in the DHCP server registration helper so that srv_unregister() always unregisters dhcp_server from pmon, aligning unregister behavior with the existing unconditional srv_register() behavior.
Changes:
Remove the #if !defined(FEATURE_RDKB_DHCP_MANAGER) guard around pmon.sh unregister dhcp_server.
Drop the associated comment about the DHCP Manager self-heal mechanism.