Skip to content

Conversation

@DaleRitchie
Copy link
Member

rebase with master azurechat branch 2025-03-28

heguro and others added 30 commits September 14, 2024 17:41
updated all GitHub action versions and Node version to make sure the pipeline deploys successfully.
Added new feature to integrate azure services using managed identities
davidxw and others added 25 commits February 14, 2025 09:49
Update profile picture for AAD and GH
… to subnets; add soft delete for key vaults and TLS encryption for storage accounts
use private endpoints
remove unused speech service parameter and add network security group…
…austomatically pull the app name from azd env
Implemented Private endpoints functionality with full compliance to Azure Enterprise Scale Landing Zone policies
Updated What's New Section
Added a bullet point about Private endpoints
@DaleRitchie DaleRitchie requested a review from Copilot March 28, 2025 00:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR rebases the branch with master and updates various documentation files and deployment workflows for the Azure Chat Solution Accelerator. The key changes include updating identity provider documentation links and instructions, adding new documentation for managed identities and private endpoints, and revising GitHub Actions workflow versions and deployment scripts.

Reviewed Changes

Copilot reviewed 37 out of 40 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
docs/9-managed-identities.md New documentation for deploying with Managed Identities
docs/9-environment-variables.md Removal of old environment variables documentation
docs/8-environment-variables.md Addition of updated environment variables documentation
docs/7-extensions.md Updated extension documentation and clarification of function calling
docs/6-persona.md Revised persona documentation with improved examples
docs/6-chat-over-file.md Removed outdated documentation on chatting with files
docs/5-chat-over-file.md New documentation for file-based chat functionality
docs/5-add-identity.md Removed old identity provider documentation
docs/4-deploy-to-azure.md Revised deployment instructions including new table formatting and guidance
docs/3-run-locally.md Removed outdated instructions for running the app locally
docs/3-add-identity.md Added updated identity provider setup documentation (GitHub and Entra ID)
docs/2-run-locally.md Added updated instructions for running the solution locally
docs/10-private-endpoints.md New documentation for configuring Azure resources with Private Endpoints
docs/1-introduction.md Updated introduction with revised version numbers and resource links
azure.yaml Updated postdeploy hook reference to the new identity provider documentation
README.md Updated documentation links and navigation structure
.github/workflows/open-ai-app.yml Updated GitHub Actions versions for Azure login, CLI, and web app deployment
Files not reviewed (3)
  • .devcontainer/devcontainer.json: Language not supported
  • infra/main.bicep: Language not supported
  • infra/main.json: Language not supported
Comments suppressed due to low confidence (2)

docs/2-run-locally.md:7

  • Consider replacing 'dependant' with 'dependent' as the correct adjective in this context.
Azure Chat is heavily dependant on a large number of Azure services. The easiest way to deploy all of these required services into an Azure subscription is to use the the [Azure Developer CLI]...

docs/10-private-endpoints.md:22

  • Typo detected: 'Developemnt' should be corrected to 'Development'.
- **Local Developemnt**: If you deploy the Azure resources with Private Endpoints it will be more difficult to use these services if you are running the application locally ...

posix:
shell: sh
run: echo -e "\n\033[0;36mTo complete the application setup you will need to configure an identity provider\033[0m\n(see the "Production App Setup" documentation at https://github.com/microsoft/azurechat/blob/main/docs/5-add-identity.md)\n"
run: echo "\n\033[0;36mTo complete the application setup you will need to configure an identity provider\033[0m\n(see the "Production App Setup" documentation at https://github.com/microsoft/azurechat/blob/main/docs/3-add-identity.md)\n"
Copy link

Copilot AI Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The echo command contains unescaped inner double quotes, which may cause shell parsing errors. Consider escaping the inner quotes (for example, use "Production App Setup" instead).

Suggested change
run: echo "\n\033[0;36mTo complete the application setup you will need to configure an identity provider\033[0m\n(see the "Production App Setup" documentation at https://github.com/microsoft/azurechat/blob/main/docs/3-add-identity.md)\n"
run: echo "\n\033[0;36mTo complete the application setup you will need to configure an identity provider\033[0m\n(see the \"Production App Setup\" documentation at https://github.com/microsoft/azurechat/blob/main/docs/3-add-identity.md)\n"

Copilot uses AI. Check for mistakes.
Copy link
Member

@RDY-AM RDY-AM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls dont break it

@DaleRitchie DaleRitchie merged commit d209dc6 into rdytech:main Mar 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

6 participants