Skip to content

fix(utils): add FC support for withSize and withDeviceRatio HOC #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chris-verclytte wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(utils): add FC support for withSize and withDeviceRatio HOC #696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/utils/src/withDeviceRatio.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ export interface WithRatioState {
}

export const withDeviceRatio = () => {
return <TProps extends WithRatioProps>(OriginalComponent: React.ComponentClass<TProps>) => {
return <TProps extends WithRatioProps>(
OriginalComponent: React.ComponentClass<TProps> | React.FunctionComponent<TProps>,
) => {
return class WithRatio extends React.Component<Omit<TProps, "ratio">, WithRatioState> {
public readonly ref = React.createRef<HTMLCanvasElement>();

Expand Down
4 changes: 3 additions & 1 deletion packages/utils/src/withSize.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ export interface WithSizeProps {
}

export const withSize = (props?: Omit<AutoSizerProps, "children">) => {
return <TProps extends WithSizeProps>(OriginalComponent: React.ComponentClass<TProps>) => {
return <TProps extends WithSizeProps>(
OriginalComponent: React.ComponentClass<TProps> | React.FunctionComponent<TProps>,
) => {
return class WithSize extends React.Component<Omit<TProps, "width" | "height">> {
public render() {
return (
Expand Down