Skip to content

Conversation

@safaiyeh
Copy link
Member

Problem

The release job was configured with || true which caused it to always succeed, even when npm publishing failed. This made it confusing to determine the actual status of releases.

Solution

Remove || true from the semantic-release command so that publishing failures are properly reported.

Changes

  • .circleci/config.yml: Remove error suppression from release command

Remove || true from semantic-release command so that publishing
failures are properly reported instead of being silently ignored.
@greptile-apps
Copy link

greptile-apps bot commented Dec 28, 2025

Greptile Summary

Removes error suppression (|| true) from the semantic-release command in the CI pipeline, allowing npm publishing failures to be properly reported instead of silently ignored.

  • The || true pattern was present since the initial CircleCI setup in 2020
  • semantic-release already handles "nothing to release" scenarios gracefully with exit code 0
  • The only failures that should occur are legitimate errors (authentication, network issues, etc.) that need visibility

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • Single-line fix that corrects a CI configuration issue - removes error suppression that was masking actual publishing failures, no logic changes to code
  • No files require special attention

Important Files Changed

Filename Overview
.circleci/config.yml Removed `

@safaiyeh safaiyeh merged commit 2a2f5a2 into master Dec 28, 2025
8 checks passed
@safaiyeh safaiyeh deleted the fix/ci-release-exit-code branch December 28, 2025 00:08
safaiyeh pushed a commit that referenced this pull request Dec 28, 2025
## [4.0.1](v4.0.0...v4.0.1) (2025-12-28)

### Bug Fixes

* **ci:** properly fail release job when npm publish fails ([#583](#583)) ([2a2f5a2](2a2f5a2))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants