-
Notifications
You must be signed in to change notification settings - Fork 80
chore(ci-cd): triger the checker workflow #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -8,7 +8,18 @@ export default function AboutPage() { | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| <title>Reactjs Developer Community in Kenya - About</title> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| </Head> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| <main className="flex justify-center items-center min-h-screen bg-white"> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| About Page here | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| <div className="max-w-4xl p-6 bg-gray-100 rounded-lg shadow-md"> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| <h1 className="text-3xl font-bold mb-4">About Us</h1> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| <p className="text-lg text-gray-700 mb-4"> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| We are a vibrant community of React.js developers in Kenya, dedicated to sharing knowledge, fostering collaboration, and promoting the use of React.js in the local tech ecosystem. Our mission is to empower developers with the skills and resources they need to build amazing applications using React.js. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| </p> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| <p className="text-lg text-gray-700 mb-4"> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| We organize regular meetups, workshops, and hackathons to bring together developers of all skill levels. Whether you're a beginner looking to learn React.js or an experienced developer seeking to connect with like-minded individuals, our community welcomes you. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| </p> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| <p className="text-lg text-gray-700"> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Join us on our journey to grow the React.js community in Kenya and make a positive impact on the tech industry. Together, we can create amazing things with React.js! | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| </p> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| </div> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| </main> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
10
to
23
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing The About page renders without the The following components should be added:
Suggested change
Don't forget the corresponding imports at the top of the file. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| </> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| ); | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
D.R.Y violation — existing
AboutUscomponent not reusedThere is already a dedicated
AboutUscomponent atsrc/components/AboutUs/AboutUs.tsxthat encapsulates the community description, and it is already being used on the homepage. This PR introduces a new inline block with different copy ("dedicated to sharing knowledge… promoting the use of React.js in the local tech ecosystem") rather than reusing the existing component.This creates two sources of truth for the same content: the homepage will show one description while the
/aboutroute shows a different one, leading to brand-messaging inconsistency.Per the project's contributing guidelines (D.R.Y principle), the existing component should be composed into this page instead of duplicating content:
If the About page intentionally needs expanded content beyond what the component currently provides, the
AboutUscomponent itself should be extended rather than duplicating it inline here.Rule Used: What: Ensure all contributions adhere to contribut... (source)