fix use_async_effect cleanup not executed when dependencies change
#1328
+68
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
use_async_effectcleanup not executed when dependencies change #1327Fixed a bug where
use_async_effectcleanup functions were not being executed when dependencies changed.This required removing
shutdown_timeoutparameter fromuse_async_effect. It is now up to the user to shield againstasyncio.CancelledErrorfor sensitive operations (such as database queries).Checklist
Please update this checklist as you complete each item:
By submitting this pull request I agree that all contributions comply with this project's open source license(s).