Update manipulating-the-dom-with-refs.md#318
Merged
arshadkazmi42 merged 9 commits intoreactjs:mainfrom Dec 24, 2024
Merged
Conversation
translated manipulating dom page.
arshadkazmi42
requested changes
Dec 24, 2024
Member
arshadkazmi42
left a comment
arshadkazmi42
left a comment
There was a problem hiding this comment.
Looks good. I have left a few minor comments. Can you take a look at those. Post that we can get this merged.
reverted name translation of example changed कंपोनेंट्स to कौम्पोनॅन्टस also some minor changes
changed कंपोनेंट to कौम्पोनॅन्ट
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
arshadkazmi42
requested changes
Dec 24, 2024
Member
arshadkazmi42
left a comment
arshadkazmi42
left a comment
There was a problem hiding this comment.
I just ran the CI and it was throwing the same error. I did some debugging and found there were few heading links were removed which was causing the issue and that is the reason you were not able to commit.
I have left the comments to fix those. please double check if another heading is missing that.
Co-authored-by: Arshad Kazmi <arshadkazmi42@gmail.com>
Co-authored-by: Arshad Kazmi <arshadkazmi42@gmail.com>
Co-authored-by: Arshad Kazmi <arshadkazmi42@gmail.com>
Contributor
Author
|
@arshadkazmi42 heading issues are fixed now hopefully 🥲 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
translated manipulating dom page.