Translation of rendering-lists#321
Merged
arshadkazmi42 merged 2 commits intoreactjs:mainfrom Jan 27, 2025
Merged
Conversation
Contributor
Author
|
New Hindi Translation Progress #168 |
Member
|
@vishnupprajapat Thank you for the PR. I will review it soon. |
arshadkazmi42
requested changes
Jan 25, 2025
Member
arshadkazmi42
left a comment
arshadkazmi42
left a comment
There was a problem hiding this comment.
Thank you for working on this. Overall looks good 👍
I have left a few minor comments, can you fix those? Once those are fixed we can merge the PR.
vishnupprajapat
commented
Jan 27, 2025
Contributor
Author
vishnupprajapat
left a comment
vishnupprajapat
left a comment
There was a problem hiding this comment.
@arshadkazmi42 I've fixed the minor comments you mentioned. Please review the changes
arshadkazmi42
approved these changes
Jan 27, 2025
Member
arshadkazmi42
left a comment
arshadkazmi42
left a comment
There was a problem hiding this comment.
Looks good 💯
Thank you for making all the changes.
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Hindi Translation Progress #168
@arshadkazmi42
Changes Proposed
Translation of rendering-lists