Skip to content

Comments

Qute support for multi module project#940

Merged
fbricon merged 1 commit intoredhat-developer:masterfrom
angelozerr:qute-projects
Sep 22, 2023
Merged

Qute support for multi module project#940
fbricon merged 1 commit intoredhat-developer:masterfrom
angelozerr:qute-projects

Conversation

@angelozerr
Copy link
Contributor

Qute support for multi module project

Fixes #930

@angelozerr
Copy link
Contributor Author

This PR requires vscode-quarkus redhat-developer/vscode-quarkus#627 PR if you wish to test it in vscode-quarkus

@angelozerr angelozerr force-pushed the qute-projects branch 3 times, most recently from c5ec2e7 to 67a229b Compare September 21, 2023 06:14
@angelozerr
Copy link
Contributor Author

angelozerr commented Sep 21, 2023

To test this PR, open https://github.com/gbourant/multi-module-template-test. The use case is that index.html from project-b include the template root.html from the project-a (where project-b have a dependency to project-a).

With this PR:

  • include root doesn't appear as an error
  • Ctrl+click on root jump to the root.html file
  • completion on #include should show root.

image

Here a demo:

QuteMultiProjectInclude

Here the limitation of the current worl:

  • it doesn'work far Java data model (like a Renarde Controller it will not be available in the template)
  • doesn't refresh new dependency (ex: if you remove project-a dependency from pom.xml in project-b it does nothing)
  • doesn't take car of added project / removed project (ex: if you add a new Qute project in the workspace it will not consider as Qute project)

@fbricon could we see those limitations in separate PR because it requires to improve the data model change event to be have more information like the new project dependencies, if teh changes comes from a java sources and dependencies, etc

@angelozerr
Copy link
Contributor Author

I need to clean my code and write tests but @fbricon you can play with the PR (please see the limitations that I have listed)

@angelozerr angelozerr requested a review from fbricon September 21, 2023 09:20
@fbricon
Copy link
Collaborator

fbricon commented Sep 21, 2023

seems to work for for includes, but not for user tags. If you create a https://github.com/gbourant/multi-module-template-test/tree/master/project-a/src/main/resources/templates /tags/link.html, then you have no completion, nor navigation for {#link} in https://github.com/gbourant/multi-module-template-test/blob/master/project-b/src/main/resources/templates/index.html

@fbricon
Copy link
Collaborator

fbricon commented Sep 21, 2023

actually if you put any user tags in project a, then all user tags in project b disappear from rendering. @mkouba is that intended? I then don't understand how Renarde works, since it also contributes user tags

@angelozerr
Copy link
Contributor Author

actually if you put any user tags in project a, then all user tags in project b disappear from rendering. @mkouba is that intended? I then don't understand how Renarde works, since it also contributes user tags

@gbourant we are using your sample (thanks for that), have you tried this usecase?

@gbourant
Copy link

actually if you put any user tags in project a, then all user tags in project b disappear from rendering. @mkouba is that intended? I then don't understand how Renarde works, since it also contributes user tags

@gbourant we are using your sample (thanks for that), have you tried this usecase?

I can confirm that this happened to me too.

That's why i moved the tags to project-b when i reported the Properties should be available recursively #939

Fixes redhat-developer#930

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr marked this pull request as ready for review September 21, 2023 15:35
@angelozerr
Copy link
Contributor Author

The PR contains now tests and the code should be cleaned, @fbricon please review it.

@fbricon fbricon merged commit 4a209b1 into redhat-developer:master Sep 22, 2023
@fbricon
Copy link
Collaborator

fbricon commented Sep 22, 2023

thanks @angelozerr

angelozerr added a commit to angelozerr/quarkus-ls that referenced this pull request Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Qute support for multi module project

3 participants