POC for avoiding waiting on vscode-microprofile#368
POC for avoiding waiting on vscode-microprofile#368datho7561 wants to merge 1 commit intoredhat-developer:masterfrom
Conversation
Work in progress. Instead of directly depending on vscode-microprofile, send the user a notification with a button to install the extension. The user can reject the installation. They will be free to use: * qute syntax highlight * properties file highlight * project generator but no new language features will appear, and they will be prompted to install vscode-microprofile when attempting to run commands that require it. Since vscode-quarkus doesn't wait on vscode-microprofile starting anymore, it can start the project generator without starting vscode-microprofile or even vscode-java. This allows for it to work in rootless mode. Closes redhat-developer#323 Signed-off-by: David Thompson <davthomp@redhat.com>
|
If I also drop vscode-java and vscode-java-debug from the This suggests to me that VS Code waits for the promise that |
|
@fbricon Do you think that removing vscode-microprofile as a extension dependency and instead providing a notification to install it in order to support this use case is a good idea? |
Maybe, maybe not. We need to test it thoroughly. |
|
I'm leaving this PR as a draft. I think that checking the extension requirements at startup instead of using the built-in VSCode |
Work in progress.
Instead of directly depending on vscode-microprofile, send the user a notification with a button to install the extension. The user can reject the installation. If they reject the installation, they will be free to use:
However, no new language features (completion/validation) will appear, and they will be prompted to install vscode-microprofile when attempting to run commands that require it.
Since vscode-quarkus doesn't list itself as depending on vscode-microprofile anymore, it can start the project generator without starting vscode-microprofile
or even vscode-java. This allows for it to work in rootless mode.Closes #323
Signed-off-by: David Thompson davthomp@redhat.com