Improve Excel API #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just simpler API, but move this edge case to a new function called get_row_kind. See #26
This was referenced Jan 5, 2026
Closed
This shortens a lot of the names (they're already in the Excel module!) I also reduced the amount of variants used for row/subrow so consumer code should be cleaner.
redstrate
force-pushed
the
work/redstrate/excel-overhaul
branch
from
9643c4a to
8d92446
Compare
More importantly, there's a way to flatten subrows in case you don't care about them.
Needed for Icarus' own iterators as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Little steps to big improvements:
excelmodule so no need to duplicate terms.get_subrow/get_row(nowsubrow/row, as said above) now returnExcelSingleRow(nowRow) to simplify the public API. More of the side-effects when using the wrong function is now clarified in the documentation.entry. The documentation tries to warn users not to depend on this.Sheet. There's also way to flatten subrow information if you know you don't need it (see [Icarus] No API for looping through every row of every page of a sheet #12 for more details behind this design.)See #26
Ports
Kawari: redstrate/Kawari#280
EXDGen (for Icarus): https://codeberg.org/redstrate/EXDGen/pulls/3
Novus: redstrate/Novus#22
libphysis: redstrate/libphysis#1