Skip to content

feat(react-sdk): add onFeaturesUpdated prop and useClient hook #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pavkam merged 3 commits into from
Feb 20, 2025
Merged

feat(react-sdk): add onFeaturesUpdated prop and useClient hook #329

pavkam merged 3 commits into from
Feb 20, 2025

Conversation

@pavkam
Copy link
Contributor

@pavkam pavkam commented Feb 20, 2025

  • Introduce onFeaturesUpdated callback in BucketProvider to allow custom handling of feature updates
  • Add new useClient() hook to access the BucketClient directly
  • Refactor hooks to use useClient() for simplified client access
  • Update README with documentation for new features

@pavkam
feat(react-sdk): add onFeaturesUpdated prop and useClient hook
4710bc2 
- Introduce `onFeaturesUpdated` callback in BucketProvider to allow custom handling of feature updates
- Add new `useClient()` hook to access the BucketClient directly
- Refactor hooks to use `useClient()` for simplified client access
- Update README with documentation for new features
@pavkam pavkam self-assigned this Feb 20, 2025
@pavkam pavkam requested a review from roncohen February 20, 2025 05:28
@roncohen
Copy link
Contributor

roncohen commented Feb 20, 2025

useClient is great! And I really like the refactor to remove ensureProvider - lets get that in!

I don't particularly like exposing onFeaturesUpdated directly. It's very specific. Since we have useClient() people can achieve the same with a on with what they get from useClient() and have access to all the events? I say let's skip that for now, but get the rest in!

@pavkam
refactor(react-sdk): remove onFeaturesUpdated prop and simplify featu…
3df87df 
…re update handling

- Remove `onFeaturesUpdated` callback from BucketProvider
- Simplify feature update event listener to directly set raw features
- Expose `Feature` type for external use
- Add `useClient()` hook test to ensure proper functionality
@pavkam
Copy link
Contributor Author

pavkam commented Feb 20, 2025

useClient is great! And I really like the refactor to remove ensureProvider - lets get that in!

I don't particularly like exposing onFeaturesUpdated directly. It's very specific. Since we have useClient() people can achieve the same with a on with what they get from useClient() and have access to all the events? I say let's skip that for now, but get the rest in!

removed the callback. Give it a 👍🏽 when you can

@pavkam pavkam merged commit 8cdade6 into browser-react-3.0.alpha Feb 20, 2025
5 checks passed
@pavkam pavkam deleted the add-features-updated-event branch February 20, 2025 13:02
roncohen pushed a commit that referenced this pull request Feb 26, 2025
@pavkam @roncohen
feat(react-sdk): add onFeaturesUpdated prop and useClient hook (#329)
4a668e2
roncohen pushed a commit that referenced this pull request Feb 26, 2025
@pavkam @roncohen
feat(react-sdk): add onFeaturesUpdated prop and useClient hook (#329)
9832b76
roncohen pushed a commit that referenced this pull request Feb 26, 2025
@pavkam @roncohen
feat(react-sdk): add onFeaturesUpdated prop and useClient hook (#329)
f69f52d
roncohen pushed a commit that referenced this pull request Feb 26, 2025
@pavkam @roncohen
feat(react-sdk): add onFeaturesUpdated prop and useClient hook (#329)
b432747
roncohen pushed a commit that referenced this pull request Feb 26, 2025
@pavkam @roncohen
feat(react-sdk): add onFeaturesUpdated prop and useClient hook (#329)
48c6eaa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roncohen roncohen roncohen approved these changes

Assignees

@pavkam pavkam

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pavkam @roncohen