Skip to content

Conversation

@roncohen
Copy link
Contributor

No description provided.

@roncohen roncohen requested a review from Swiftwork February 26, 2025 12:08
@roncohen
Copy link
Contributor Author

one more!

@roncohen roncohen enabled auto-merge (squash) February 26, 2025 12:08
@roncohen roncohen disabled auto-merge February 26, 2025 12:08
@roncohen roncohen changed the title docs(react-sdk): Improve getting started with Remote config docs: Remote config docs improvements Feb 26, 2025
@roncohen roncohen enabled auto-merge (squash) February 26, 2025 12:08
Copy link
Contributor

@Swiftwork Swiftwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI suggestions

General Improvements

Ensure consistency in capitalization (e.g., "JavaScriptS/Typescript" should be "JavaScript/TypeScript").
Verify that all headings follow a consistent format (e.g., some headings use parentheses for "beta" while others do not).

Specific Improvements

packages/browser-sdk/README.md
Line 5: "collecting feedback" should link correctly to the qualitative feedback section.
Line 5: "remotely configuring features" should link correctly to the remote config section.
Line 197: "Remote config (beta)" should be consistently applied across all README files.
Line 217: "If feature has no configuration or, no configuration value was matched against the context, the config object will be empty" should be corrected to "If a feature has no configuration or no configuration value was matched against the context, the config object will be empty."
Line 234: "The key is always present while the payload is a optional JSON value for arbitrary configuration needs" should be corrected to "The key is always present while the payload is an optional JSON value for arbitrary configuration needs."
packages/node-sdk/README.md
Line 3: "JavaScriptS/Typescript" should be corrected to "JavaScript/TypeScript".
Line 5: Ensure consistent linking for "collecting feedback" and "remotely configuring features".
Line 229: "Remote config (beta)" should be consistently applied across all README files.
Line 249: "If feature has no configuration or, no configuration value was matched against the context, the config object will be empty" should be corrected to "If a feature has no configuration or no configuration value was matched against the context, the config object will be empty."
Line 218: "The key is always present while the payload is a optional JSON value for arbitrary configuration needs" should be corrected to "The key is always present while the payload is an optional JSON value for arbitrary configuration needs."

@roncohen roncohen merged commit 42c79e7 into main Feb 26, 2025
5 checks passed
@roncohen roncohen deleted the more-docs-fixes branch February 26, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants