-
Notifications
You must be signed in to change notification settings - Fork 11
Toolbar: handle many features, tweak stagger anim #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or when theres many features
Contributor
|
how about limiting the height/number of shown features to some static number? A huge list isn't useful - you'll use the search anyway. Also, the huge lists takes up a ton of real estate and messes with the feeing that the toolbar is small and light weight. Keeping it limited in height helps it to feel light weight even when you have a ton of features. |
…/bucketco/bucket-javascript-sdk into buc-3360-handle-lots-of-features
roncohen
reviewed
Feb 27, 2025
roncohen
reviewed
Feb 27, 2025
roncohen
approved these changes
Feb 28, 2025
laander
added a commit
that referenced
this pull request
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle many features:
Kapture.2025-02-27.at.12.40.58.mp4
We show a staggered entrance animation for each feature. But if the stagger delay is static and you have a lot of features, that might result in a (too) long animation. So instead, we adjust the stagger delay according to the amount of features in the list so the total animation duration never exceeds 75ms. Here's a demonstration:
Kapture.2025-02-27.at.11.43.20.mp4